- implementations-list - lists.ourproject.org

What private changes to Viper and/or Vimpulse do you have in your .emacs file?
by Jason Spiro 25 Jul '10

25 Jul '10

Hi all, I am curious: what private changes to Viper and/or Vimpulse do you have in your .emacs file? You can tell us: 1. an English-language summary of what your code does, or 2. the code itself, or 3. both. Cheers, -Jason

5 7

[PATCH/RFC] Add some tips for contributors.
by Štěpán Němec 25 Jul '10

25 Jul '10

--- [Side note: Committing people's patches edited is a no no. At least I strongly prefer having a discussion and resending the patch, possibly several times, to having my patch edited (and possibly borken, which seems to have happened with 9b9c0298530) and committed under my name. Or being asked "I'll commit this instead/squash these changes in, OK?".] .gitattributes | 1 + CONTRIBUTE | 32 ++++++++++++++++++++++++++++++++ Header | 3 ++- 3 files changed, 35 insertions(+), 1 deletions(-) create mode 100644 .gitattributes create mode 100644 CONTRIBUTE diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..b362cfa --- /dev/null +++ b/.gitattributes @@ -0,0 +1 @@ +*.el diff=lisp diff --git a/CONTRIBUTE b/CONTRIBUTE new file mode 100644 index 0000000..70988e4 --- /dev/null +++ b/CONTRIBUTE @@ -0,0 +1,32 @@ +So you want to contribute? That's great, thank you! Here are some tips that +will help you make us cry with delight at the very sight of your patch: + +Patch format +------------ +- it's best if the patches are directly processable by Git (such as when using + `git-format-patch', `git-send-email' or the ---8<--- scissors trick) +- a nice way to have Git produce better diff hunk headers when working with + Lisp code is to add this to your config: + +[diff "lisp"] + xfuncname = "^\\(.*$" + +With this and an appropriate diff attribute definition (provided by the +.gitattributes file in the repository), it will be immediately visible which +top level Lisp form a particular hunk pertains to. + +Commit messages +--------------- +- the first line is a commit summary, usually a single sentence in imperative + (starting with a capital letter and ending with a period) short enough to fit + in a mail subject line +- after that and a blank line comes the commit message with a free form + explanation (optional for trivial patches) + +General coding guidelines +------------------------- +- keep it inside 80 columns when possible +- avoid trailing whitespace (Git can help you with that) +- if you're making bigger changes, it's a good idea to try byte-compiling + Vimpulse even though you normally don't (the compiler sometimes catches + issues not obvious when running uncompiled) diff --git a/Header b/Header index 99661ce..1b07281 100644 --- a/Header +++ b/Header @@ -41,5 +41,6 @@ ;; ;; Vimpulse is under active development. It works quite well with ;; GNU Emacs 22.3 and 23.2, as well as XEmacs 21.4.22. Patches and -;; feature requests are welcome. +;; feature requests are welcome (see also the file CONTRIBUTE in the +;; repository). -- 1.7.1

3 10

[PATCH] fixes issue where dT<char>/dF<char> would delete more than expected
by Tim Harper 25 Jul '10

25 Jul '10

given: (this-is-some-text|) dTe would result in: (this-is-some-t| dFe would result in given: (this-is-some-| This change resolves the issue by setting these operators to be exclusive, rather than incluse. --- vimpulse-operator.el | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vimpulse-operator.el b/vimpulse-operator.el index fd9acda..8c985bb 100644 --- a/vimpulse-operator.el +++ b/vimpulse-operator.el @@ -742,12 +742,12 @@ type TYPE. A custom function body may be specified via BODY." ;; These motions need wrapper functions to repeat correctly. (vimpulse-operator-map-define viper-end-of-Word 'inclusive) (vimpulse-operator-map-define viper-end-of-word 'inclusive) -(vimpulse-operator-map-define viper-find-char-backward 'inclusive) +(vimpulse-operator-map-define viper-find-char-backward 'exclusive) (vimpulse-operator-map-define viper-find-char-forward 'inclusive) (vimpulse-operator-map-define viper-forward-Word 'exclusive) (vimpulse-operator-map-define viper-forward-char 'inclusive) (vimpulse-operator-map-define viper-forward-word 'exclusive) -(vimpulse-operator-map-define viper-goto-char-backward 'inclusive) +(vimpulse-operator-map-define viper-goto-char-backward 'exclusive) (vimpulse-operator-map-define viper-goto-char-forward 'inclusive) (vimpulse-operator-map-define viper-search-backward 'exclusive) (vimpulse-operator-map-define viper-search-forward 'exclusive) -- 1.7.1.1

2 2

Bug: dired bindings break Ex commands.
by Serguei Jidkov 24 Jul '10

24 Jul '10

Hi everyone! I'm yet another long time vim user trying to make a transition to emacs. Recently I've discovered vimpulse and, suddenly, emacs started to look much more usable. :) Thanks for making this great package! Sure, it's not without its quirks but I still find it life-saving (or fingers-saving, at the very least). Here is a little bug in the current git master I've discovered just before switching vimpulse-wants-vi-keys-in-* variables off. In vimpulse-compatibility.el: > (eval-after-load 'dired > '(when vimpulse-want-vi-keys-in-dired > ;; [... snip ...] > (add-to-list 'ex-token-alist '("e" (epa-dired-do-encrypt))) > (add-to-list 'ex-token-alist '("s" (epa-dired-do-sign))) > (add-to-list 'ex-token-alist '("v" (epa-dired-do-verify))) > (add-to-list 'ex-token-alist '("d" (epa-dired-do-decrypt))) > (viper-modify-major-mode 'dired-mode 'vi-state map)))) I guess the idea was to add buffer local Ex commands, but it doesn't work. Once dired mode is entered, commands get overwritten globally. After that every attempt to use :e fails with "dired-move-to-filename: No file on this line" message. Of course unsetting `vimpulse-wants-vi-keys-in-dired' "solves" the problem, as does removing of the `add-to-list' expressions. But maybe you will want to do something more creative about it. :)

2 1

XEmacs has no [remap].
by Štěpán Němec 23 Jul '10

23 Jul '10

Subject line says it all. I learned about that only today accidentally from this mail on emacs-devel: <http://permalink.gmane.org/gmane.emacs.devel/127667> Vimpulse uses remapping at a few places so I thought I'd mention that, as AFAIK Vegard tries to keep things XEmacs-compatible (and has my full moral support ;-D). I'm not suggesting we do anything about that, at least until some complaints occur. (:rant It's so sad, really -- I'd love to be using XEmacs (see the recent copyright thread on this list), but it seems to only work reasonably well out-of-the-box in the terminal for me. I'm sure you can get it working in GUI, too, but my hostility towards the FSF probably just isn't big enough yet. :-|) Štěpán

2 4

[PATCH] Bugfix: no longer selects next word when invoking 'viw' at end of a word
by Tim Harper 23 Jul '10

23 Jul '10

--- vimpulse-text-object-system.el | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/vimpulse-text-object-system.el b/vimpulse-text-object-system.el index bdfea28..33acc59 100644 --- a/vimpulse-text-object-system.el +++ b/vimpulse-text-object-system.el @@ -410,6 +410,7 @@ specifies whether to include the quote marks in the range." (viper-backward-word (cons arg ?r)))) (lambda (arg) (vimpulse-limit (line-beginning-position) (line-end-position) + (backward-char) (viper-end-of-word (cons arg ?r)))))) (vimpulse-define-text-object vimpulse-a-Word (arg) -- 1.7.1.1

2 1

[PATCH] ignore elc files
by Tim Harper 23 Jul '10

23 Jul '10

--- .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..c531d98 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +*.elc -- 1.7.1.1

2 1

[PATCH] Fixes deactivate-mark issue when expanding selection to text-objects
by Tim Harper 23 Jul '10

23 Jul '10

When CUA mode is active, commands such as viw, viW, vis, etc. would exit visual mode because cua-mode, on activation, sets deactivate-mark to t, and deactivate-mark isn't protected by save-excursion. This change prevents that, and therefore fixes this issue. --- vimpulse-visual-mode.el | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/vimpulse-visual-mode.el b/vimpulse-visual-mode.el index a9c0240..2430d0a 100644 --- a/vimpulse-visual-mode.el +++ b/vimpulse-visual-mode.el @@ -281,9 +281,10 @@ Saves the previous state of Transient Mark mode in (transient-mark-mode 1) (transient-mark-mode -1))) (when (boundp 'cua-mode) - (if (vimpulse-visual-before cua-mode) - (cua-mode 1) - (cua-mode -1))) + (let (deactivate-mark) ;; prevent cua-mode from setting deactivate-mark to t + (if (vimpulse-visual-before cua-mode) + (cua-mode 1) + (cua-mode -1)))) (when (boundp 'zmacs-regions) (let ((oldval (vimpulse-visual-before zmacs-regions))) (setq zmacs-regions oldval))))) -- 1.7.1.1

2 2

Strange visual-line bug
by Tim Harper 23 Jul '10

23 Jul '10

After a while of using vimpulse mode in a buffer, it gets into a strange state where if I go from vi-mode to visual-line-select mode by pressing "V", it "remembers" my previous visual-line-selection (cursor position, number lines selected and all) and takes me back to it. This is undesirable, naturally. I don't know exactly how to reproduce the bug, but have managed to record a video of it in action: http://screencast.com/t/YjBlMmVkMjQ The buggy-state is buffer-local. Killing a buffer, and then re-opening the file, restores sanity, as demonstrated in the video. Thanks for vimpulse mode! Tim

2 2

Re: Strange visual-line bug
by Tim Harper 22 Jul '10

22 Jul '10

Hah, that's the coolest report so far? Awesome! seriously I use video because I'm lazy... its a ton of work to serialize an experience into text. I'm using GNU emacs, 23.2. (Cocoa integration was merged in for 23) Interesting that its caused by visual line mode being deactivated properly... before I apply your patch, ill play around a little more and see if I can see what leads to it, but being fault tolerant never hurts... it's a jungle in emacs. Tim On Jul 21, 2010 3:40 AM, "Vegard Øye" <vegard_oye(a)hotmail.com> wrote: On 2010-07-20 16:12, Tim Harper wrote: > I don't know exactly how to reproduce the bug, but have ma... Hi Tim! Welcome to the list, and thanks for the coolest bug report so far :) Let's get the basics out of the way first. Is that Aquamacs (what version?), and are you using the latest developmental commit of Vimpulse? I don't know exactly why this happens, but I've been able to reproduce it by injecting a "bad value" into one of Visual mode's buffer-local variables. It seems that somehow Visual mode isn't deactivated properly and that a faulty variable causes problems upon reactivation. The variable is remembered across Visual sessions, giving rise to a persistent "buggy state". Furthermore, as the restoration of the previous selection occurs in `post-command-hook' -- after hl-line-mode et al. have refreshed their own highlighting -- the other modes aren't able to pick up on it, and so their highlighting doesn't coincide with Visual mode's. Commit [9d1af90898] should be more robust with regard to such values. Let me know if the bug persists. -- Vegard _______________________________________________ implementations-list mailing list implementations-list(a)lists.ourproject.org https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list

3 5