Hah, that's the coolest report so far? Awesome! seriously I use video because I'm lazy... its a ton of work to serialize an experience into text. I'm using GNU emacs, 23.2. (Cocoa integration was merged in for 23) Interesting that its caused by visual line mode being deactivated properly... before I apply your patch, ill play around a little more and see if I can see what leads to it, but being fault tolerant never hurts... it's a jungle in emacs. Tim On Jul 21, 2010 3:40 AM, "Vegard Øye" <[email protected]> wrote: On 2010-07-20 16:12, Tim Harper wrote:
I don't know exactly how to reproduce the bug, but have ma... Hi Tim!
Welcome to the list, and thanks for the coolest bug report so far :) Let's get the basics out of the way first. Is that Aquamacs (what version?), and are you using the latest developmental commit of Vimpulse? I don't know exactly why this happens, but I've been able to reproduce it by injecting a "bad value" into one of Visual mode's buffer-local variables. It seems that somehow Visual mode isn't deactivated properly and that a faulty variable causes problems upon reactivation. The variable is remembered across Visual sessions, giving rise to a persistent "buggy state". Furthermore, as the restoration of the previous selection occurs in `post-command-hook' -- after hl-line-mode et al. have refreshed their own highlighting -- the other modes aren't able to pick up on it, and so their highlighting doesn't coincide with Visual mode's. Commit [9d1af90898] should be more robust with regard to such values. Let me know if the bug persists. -- Vegard _______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2010-07-21 15:58, Tim Harper wrote:
I'm using GNU emacs, 23.2. (Cocoa integration was merged in for 23)
Ah, okay. Looks good.
Interesting that its caused by visual line mode being deactivated properly... before I apply your patch, ill play around a little more and see if I can see what leads to it, but being fault tolerant never hurts... it's a jungle in emacs.
There is no patch -- just use git pull to obtain the latest commits. On the other hand, if you want to contribute code, do a local commit and use git format-patch to produce a patch for list submission. Then, when I apply the patch (with git am), your name and commits will show up in the official repository just as they do locally. -- Vegard
On Thu, Jul 22, 2010 at 9:51 AM, Vegard Øye <[email protected]> wrote:
On 2010-07-21 15:58, Tim Harper wrote:
I'm using GNU emacs, 23.2. (Cocoa integration was merged in for 23)
Ah, okay. Looks good.
Interesting that its caused by visual line mode being deactivated properly... before I apply your patch, ill play around a little more and see if I can see what leads to it, but being fault tolerant never hurts... it's a jungle in emacs.
There is no patch -- just use git pull to obtain the latest commits. On the other hand, if you want to contribute code, do a local commit and use git format-patch to produce a patch for list submission. Then, when I apply the patch (with git am), your name and commits will show up in the official repository just as they do locally.
Right, that's what was referring to, sorry to confuse the terms. "Patch" seems to be used pretty loosely around git folk. Familiar with git format-patch / git am, will plan on contributing accordingly. I've got my own public repo on github though where I experiment with things as well, do you take pull requests that way? (and why aren't you on github!? :) ) Tim
Tim Harper <[email protected]> writes:
Familiar with git format-patch / git am, will plan on contributing accordingly. I've got my own public repo on github though where I experiment with things as well, do you take pull requests that way? (and why aren't you on github!? :) )
GitHub is overrated. :-P Seriously, it's not even Free Software! If you really insisted on having Vimpulse somewhere more "cool" than Assembla, I'd suggest Gitorious, not GitHub. Not only because Gitorious is libre, but also because it's project-centric, not person-centric as GitHub. Anyway, I personally really like the mailing list model -- when you send patches to a mailing list, more people have chance to look at it and chime in when they have anything to say on the matter. Štěpán
On 7/22/2010 1:23 PM, Štěpán Němec wrote:
Tim Harper<[email protected]> writes:
Familiar with git format-patch / git am, will plan on contributing accordingly. I've got my own public repo on github though where I experiment with things as well, do you take pull requests that way? (and why aren't you on github!? :) ) GitHub is overrated. :-P Seriously, it's not even Free Software!
LOL, okay, you have a point there.
If you really insisted on having Vimpulse somewhere more "cool" than Assembla, I'd suggest Gitorious, not GitHub. Not only because Gitorious is libre, but also because it's project-centric, not person-centric as GitHub.
You can set up organizations in GitHub now, which you can use as a project centric location
Anyway, I personally really like the mailing list model -- when you send patches to a mailing list, more people have chance to look at it and chime in when they have anything to say on the matter. This is a good point, and it has its merits. However, have you ever used the network browser in GitHub? It makes it really easy for people to have multiple forks of a project, and if somebody happens to create a patch that, for whatever reason, isn't merged in, it makes it really easy to find. (I've used it many times to find patches for abandoned projects).
I was mostly teasing about moving to GitHub, but I really like it. It's a great place for open source to live, and it's really well done. I don't think it's overrated :-)
Štěpán
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
Tim Harper <[email protected]> writes:
If you really insisted on having Vimpulse somewhere more "cool" than Assembla, I'd suggest Gitorious, not GitHub. Not only because Gitorious is libre, but also because it's project-centric, not person-centric as GitHub.
You can set up organizations in GitHub now, which you can use as a project centric location
Didn't know about that, thanks. (<http://github.com/blog/674-introducing-organizations> for anyone interested)
Anyway, I personally really like the mailing list model -- when you send patches to a mailing list, more people have chance to look at it and chime in when they have anything to say on the matter. This is a good point, and it has its merits. However, have you ever used the network browser in GitHub? It makes it really easy for people to have multiple forks of a project, and if somebody happens to create a patch that, for whatever reason, isn't merged in, it makes it really easy to find. (I've used it many times to find patches for abandoned projects).
Yeah, the network browser is nice, as are other GitHub features, although I don't really have any use for them. :-) Maybe it's just me, but I really prefer the "traditional" e-mail + patches way (even with projects that use GitHub and even though I do have a GitHub account). Git makes that totally painless anyway and the open discussion possibilities are unmatched by the hosting sites' fancy features. Maybe Web 2.0/3.0 whatever is the future with things like Google Wave and whatnot, but right now it all just feels like too much hassle (no unified UI, best-used-with-a-"modern"-browser, being tied to a particular provider etc.) for too little or no profit to me compared to e-mail. Štěpán
participants (3)
-
Tim Harper -
Vegard Øye -
Štěpán Němec