- implementations-list - lists.ourproject.org

[implementations-list] [Vimpulse] Fixing things in Vimpulse vs. Viper; XEmacs support (was: Bug: something's worng when pasting whole lines:)
by Jason Spiro 25 May '10

25 May '10

On Tue, May 18, 2010 at 1:14 PM, Vegard Øye <vegard_oye(a)hotmail.com> wrote: > Yes, this is the "right" way to do it. What Viper does is to check if > the text to be pasted ends with a newline, which might fail at the end > of the buffer. (But that doesn't seem to be the problem here.) > > I should probably reimplement block pasting in terms of yank-handler, > and maybe redefine the `viper-[Pp]ut-back' functions, too. But then > there's XEmacs ... If you want to fix this, why would you fix it in Vimpulse? Why not in Viper? :) > ... > TBH, if it weren't for the fact that Viper supports XEmacs already, I > would never have bothered with XEmacs compatibility. And I think > Vimpulse would have been better off without it. Every time I encounter > some XEmacs idiosyncracy needing special treatment, Vimpulse's code > inevitably grows exponentially, no matter how hard I try to do things > "cleanly" with reuseable functions that do what I want depending on > the circumstances. You're the maintainer. It's 100% fine for you to stop supporting XEmacs if you want. If you do so, may I suggest you put in a message in the documentation stating what the last XEmacs-compatible Vimpulse version is, and pointing out that someone else can take over XEmacs support if they want. If you want, you can also decide that all the new XEmacs support code that people contribute from now on must go into a separate file in the Vimpulse source tree. But that might be a bit of a harsh decree. :) -- Jason Spiro: software/web developer, packager, trainer, IT consultant. I support Linux, UNIX, Windows, and more. Contact me to discuss your needs. +1 (416) 992-3445 / www.jspiro.com

1 0

[implementations-list] [JUNK] This is a test message
by Štěpán Němec 25 May '10

25 May '10

Greets from an unsubscribed address! This message just tests if subscription is actually required for posting to the list. Sorry for the spam (in case it gets through). Štěpán

4 4

[implementations-list] flyspell-prog-mode, etc. (was: Upcoming release)
by Jason Spiro 25 May '10

25 May '10

On Mon, Apr 26, 2010 at 6:49 AM, Vegard Øye <vegard_oye(a)hotmail.com> wrote: > Ouch, how embarrassing. :) I know I have made this misspelling in the > past, too. Everyone makes English mistakes sometimes. :) If you're concerned about it, may I suggest you use Vim's ":set spell" command, or Emacs flyspell-prog-mode. They automatically spell-check comments and strings only. ... > Yeah, it's probably a good idea not to get stuck with small version > numbers. I plan to replace redo.el with Toby Cubitt's awesome > undo-tree.el package, which means Vimpulse's dependencies will change; > the version number should reflect that. 0.3.3 will probably be too > subtle. > > This will be 0.4, then, and probably the last release to use redo.el. > If so, it will be succeeded by 0.5. When will 1.0 be? :) -- Jason Spiro: software/web developer, packager, trainer, IT consultant. I support Linux, UNIX, Windows, and more. Contact me to discuss your needs. +1 (416) 992-3445 / www.jspiro.com

3 3

[implementations-list] [PATCH] Remove unused undo-list-munging code.
by Štěpán Něm ec 22 May '10

22 May '10

--- While looking at the code, I noticed that all of this is currently unused. Is that just an oversight, or are you actually planning to use it in the future? If the former, this patch could safely be applied, unless I'm missing something. vimpulse-dependencies.el | 6 ------ vimpulse-visual-mode.el | 31 +------------------------------ 2 files changed, 1 insertions(+), 36 deletions(-) diff --git a/vimpulse-dependencies.el b/vimpulse-dependencies.el index 7b12562..57754e7 100644 --- a/vimpulse-dependencies.el +++ b/vimpulse-dependencies.el @@ -337,12 +337,6 @@ (viper-deflocalvar vimpulse-visual-whitespace-overlay nil "Overlay encompassing text inserted into the buffer to make Block selection at least one column wide.") -(viper-deflocalvar vimpulse-undo-needs-adjust nil - "If true, several commands in the undo-list should be connected.") - -(defconst vimpulse-buffer-undo-list-mark 'vimpulse - "Everything up to this mark is united in the undo-list.") - (defvar vimpulse-visual-height nil "Height of last Visual selection.") diff --git a/vimpulse-visual-mode.el b/vimpulse-visual-mode.el index c3adea4..955c209 100644 --- a/vimpulse-visual-mode.el +++ b/vimpulse-visual-mode.el @@ -859,33 +859,6 @@ (defun vimpulse-visual-remap (from to) "Remap FROM to TO in Visual mode." (vimpulse-remap vimpulse-visual-basic-map from to)) -(defun vimpulse-filter-undos (undo-list) - "Filters all `nil' marks from `undo-list' until the first -occurrence of `vimpulse-buffer-undo-list-mark'." - (cond - ((null undo-list) - nil) - ((eq (car undo-list) 'vimpulse) - (cdr undo-list)) - ((null (car undo-list)) - (vimpulse-filter-undos (cdr undo-list))) - (t - (cons (car undo-list) - (vimpulse-filter-undos (cdr undo-list)))))) - -(defun vimpulse-connect-undos () - "Connects all undo-steps from `buffer-undo-list' up to the -first occurrence of `vimpulse-buffer-undo-list-mark'." - (when (and vimpulse-undo-needs-adjust - (listp buffer-undo-list)) - (setq buffer-undo-list - (vimpulse-filter-undos buffer-undo-list))) - (setq vimpulse-undo-needs-adjust nil)) - -(defun vimpulse-push-buffer-undo-list-mark () - (setq vimpulse-undo-needs-adjust t) - (push vimpulse-buffer-undo-list-mark buffer-undo-list)) - ;;; Ex (defun vimpulse-visual-ex (arg) @@ -1232,9 +1205,7 @@ (defun vimpulse-exit-insert-state () (move-to-column (1+ col) t) ; append spaces (viper-repeat nil))) (viper-repeat nil))))) - (setq vimpulse-visual-insert-coords nil))) - ;; Update undo-list - (vimpulse-connect-undos)) + (setq vimpulse-visual-insert-coords nil)))) (fset 'viper-exit-insert-state 'vimpulse-exit-insert-state) -- 1.7.1

3 3

[implementations-list] [Vimpulse] Bug: something's worng when pasting whole lines:
by Alessandro Piras 19 May '10

19 May '10

;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. If the cursor is at the beginning of the buffer and for example I do jVjyP the result is ;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer.;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. Alessandro Piras

4 10

[implementations-list] [vimpulse/viper] bug: ~ (tilde) doesn't forward char after changing the case of the character at point.
by Alessandro Piras 18 May '10

18 May '10

no need for further explanations i guess

2 2

[implementations-list] [Vimpulse] bug(?): vimpulse breaks dired-x
by Alessandro Piras 15 May '10

15 May '10

Something in vimpulse or its dependencies clashes with dired-x: This is what happens when I (require 'dired-x) if vimpulse is loaded: Is vimpulse remapping M-o? ebugger entered--Lisp error: (error "Key sequence M-o starts with non-prefix key ") define-key((keymap #^[nil nil keymap #^^[3 0 nil nil nil nil nil nil nil nil viper-backward-char nil bookmarkp-dired-jump-current nil nil dired-find-file viper-next-line dired-display-file viper-previous-line nil nil nil ... nil nil nil ... nil nil viper-intercept-ESC-key nil nil nil nil viper-forward-char dired-do-shell-command nil dired-flag-auto-save-files dired-hide-subdir ... dired-do-async-shell-command nil nil nil ... dired-create-directory nil negative-argument dired-clean-directory nil ...] #^^[1 0 #^^[2 0 #^^[3 0 nil nil nil nil nil nil nil nil viper-backward-char nil bookmarkp-dired-jump-current nil nil dired-find-file viper-next-line dired-display-file viper-previous-line nil nil nil ... nil nil nil ... nil nil viper-intercept-ESC-key nil nil nil nil viper-forward-char dired-do-shell-command nil dired-flag-auto-save-files dired-hide-subdir ... dired-do-async-shell-command nil nil nil ... dired-create-directory nil negative-argument dired-clean-directory nil ...] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil ...] (backspace . viper-backward-char) (menu-bar keymap (operate "Operate" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Operate") (mark "Mark" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Mark") (regexp "Regexp" keymap ... ... ... ... ... ... ... ... ... ... ... "Regexp") (immediate "Immediate" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Immediate") (subdir "Subdir" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... "Subdir")) (up . dired-previous-line) (down . dired-next-line) (follow-link . mouse-face) (mouse-2 . dired-mouse-find-file-other-window) (remap keymap (vimpulse-visual-insert . viper-nil) (vimpulse-visual-append . viper-nil) (vimpulse-delete . viper-nil) (vimpulse-change . viper-nil) (viper-substitute-line . viper-nil) (viper-substitute . viper-nil) (viper-kill-line . viper-nil) (viper-insert . viper-nil) (viper-command-argument . viper-nil) (viper-change-to-eol . viper-nil) (viper-append . viper-nil) (viper-Insert . viper-nil) (viper-Append . viper-nil) (advertised-undo . dired-undo) (undo . dired-undo) (self-insert-command . undefined))) "\357" dired-omit-mode) byte-code("\306 \307\310#\210\306 \311\312#\210\306 \313\314#\210\306 \315\314#\210\306 \316\317#\210\306 \320\321#\210\306 \322\323#\210\306 \324\325#\210\306 \326\327#\210\306 \330\331#\210\306 \332\333#\210\306 \334\335#\210 \203R Alessandro Piras

2 1

[implementations-list] Reading commit 1b34d16a226
by Štěpán Němec 15 May '10

15 May '10

+ (when (< 23.2 (progn (string-match "^[0-9]+\\.[0-9]+" + emacs-version) + (string-to-number + (match-string 0 emacs-version)))) Why not (version< "23.2" emacs-version) instead of the clumsy matching and type conversion? (Just don't ask what the `version<' function does internally ;-).) (Not mentioning the fact that your + ;; Restore dabbrev variables if version < 23.2 comment suggests the exact opposite of what the code actually does.)

2 10

[implementations-list] [PATCH] Define a proper prefix command for the "\C-w" map.
by Štěpán Němec 12 May '10

12 May '10

This makes customization and rebinding possible. --- Example (why I felt the need): Now I can (eval-after-load 'vimpulse '(define-key term-raw-escape-map "\C-w" 'vimpulse-window-map)) to be able to use Vimpulse window bindings in Emacs' term modes. vimpulse-misc-keybindings.el | 23 ++++++++++++----------- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/vimpulse-misc-keybindings.el b/vimpulse-misc-keybindings.el index 3a6c723..49f25d9 100644 --- a/vimpulse-misc-keybindings.el +++ b/vimpulse-misc-keybindings.el @@ -64,19 +64,20 @@ (define-key viper-vi-basic-map "\C-r" 'redo))) ;; Window manipulation -(define-key viper-vi-basic-map "\C-w" (make-sparse-keymap)) -(define-key viper-vi-basic-map "\C-w\C-w" 'vimpulse-cycle-windows) -(define-key viper-vi-basic-map "\C-ww" 'vimpulse-cycle-windows) -(define-key viper-vi-basic-map "\C-wo" 'delete-other-windows) -(define-key viper-vi-basic-map "\C-wc" 'delete-window) -(define-key viper-vi-basic-map "\C-ws" 'split-window-vertically) -(define-key viper-vi-basic-map "\C-wv" 'split-window-horizontally) +(define-prefix-command 'vimpulse-window-map) +(define-key viper-vi-basic-map "\C-w" 'vimpulse-window-map) +(define-key vimpulse-window-map "\C-w" 'vimpulse-cycle-windows) +(define-key vimpulse-window-map "w" 'vimpulse-cycle-windows) +(define-key vimpulse-window-map "o" 'delete-other-windows) +(define-key vimpulse-window-map "c" 'delete-window) +(define-key vimpulse-window-map "s" 'split-window-vertically) +(define-key vimpulse-window-map "v" 'split-window-horizontally) (when (fboundp 'windmove-left) - (define-key viper-vi-basic-map "\C-wh" 'windmove-left) - (define-key viper-vi-basic-map "\C-wj" 'windmove-down) - (define-key viper-vi-basic-map "\C-wk" 'windmove-up) - (define-key viper-vi-basic-map "\C-wl" 'windmove-right)) + (define-key vimpulse-window-map "h" 'windmove-left) + (define-key vimpulse-window-map "j" 'windmove-down) + (define-key vimpulse-window-map "k" 'windmove-up) + (define-key vimpulse-window-map "l" 'windmove-right)) ;;; Insert mode keys -- 1.7.1

2 1

[implementations-list] [PATCH] Sanitize the folding setup.
by Štěpán Němec 12 May '10

12 May '10

Don't force `global-reveal-mode' upon users; this unbreaks at least Org and Allout modes. When we're at it, also - don't use anonymous functions in hooks and key bindings (this sloppy practice should stay limited to user code) - fix erroneous customize type of `vimpulse-fold-level' - remove unused `vimpulse-hs-Open' definition - don't call `hs-hide-all' interactively (makes no sense) --- This patch doesn't improve the existing folding functionality, only prevents it from breaking other Emacs modes. I don't use Vimpulse folding, but testing didn't suggest any breakage there (unless you consider preventing somewhat undeterministic behaviour with Reveal mode on all the time a breakage). vimpulse-compatibility.el | 39 +++++++++++---------------------------- vimpulse-dependencies.el | 2 +- 2 files changed, 12 insertions(+), 29 deletions(-) diff --git a/vimpulse-compatibility.el b/vimpulse-compatibility.el index e40ceb3..210927f 100644 --- a/vimpulse-compatibility.el +++ b/vimpulse-compatibility.el @@ -279,36 +279,19 @@ Disable anyway if FORCE is t." ;;; Folding -;; Almost all of this code is taken from extended-viper -;; coded by Brad Beveridge (bradbev at gmail.com) -;; - I changed the prefix of the custom functions to `vimpulse' -;; to avoid multiple prefixes (eval-after-load 'hideshow '(progn - (defun vimpulse-hs-Open () + (defun vimpulse-za () (interactive) - (hs-show-block) - (hs-hide-level -1)) - (add-hook 'hs-minor-mode-hook - (lambda () - (call-interactively 'hs-hide-all) - (define-key viper-vi-basic-map "za" - (lambda () - (interactive) - (hs-toggle-hiding) - (hs-hide-level vimpulse-fold-level))) - (define-key viper-vi-basic-map "za" 'hs-toggle-hiding) - (define-key viper-vi-basic-map "zm" 'hs-hide-all) - (define-key viper-vi-basic-map "zr" 'hs-show-all) - (define-key viper-vi-basic-map "zo" 'hs-show-block) - (define-key viper-vi-basic-map "zc" 'hs-hide-block))))) - -;; Load reveal.el if available -(unless (featurep 'reveal) - (condition-case nil - (require 'reveal) - (error nil))) -(when (fboundp 'global-reveal-mode) - (global-reveal-mode 1)) + (hs-toggle-hiding) + (hs-hide-level vimpulse-fold-level)) + (defun vimpulse-hs-setup () + (hs-hide-all) + (define-key viper-vi-basic-map "za" 'vimpulse-za) + (define-key viper-vi-basic-map "zm" 'hs-hide-all) + (define-key viper-vi-basic-map "zr" 'hs-show-all) + (define-key viper-vi-basic-map "zo" 'hs-show-block) + (define-key viper-vi-basic-map "zc" 'hs-hide-block)) + (add-hook 'hs-minor-mode-hook 'vimpulse-hs-setup))) (provide 'vimpulse-compatibility) diff --git a/vimpulse-dependencies.el b/vimpulse-dependencies.el index db90644..f37a2ec 100644 --- a/vimpulse-dependencies.el +++ b/vimpulse-dependencies.el @@ -102,7 +102,7 @@ Off by default." (defcustom vimpulse-fold-level 0 "Default fold level." - :type 'boolean + :type 'integer :group 'vimpulse) ;; The secrets discovered from untold diggings among -- 1.7.1

2 1