[PATCH] fixes issue where dT<char>/dF<char> would delete more than expected
given: (this-is-some-text|) dTe would result in: (this-is-some-t| dFe would result in given: (this-is-some-| This change resolves the issue by setting these operators to be exclusive, rather than incluse. --- vimpulse-operator.el | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vimpulse-operator.el b/vimpulse-operator.el index fd9acda..8c985bb 100644 --- a/vimpulse-operator.el +++ b/vimpulse-operator.el @@ -742,12 +742,12 @@ type TYPE. A custom function body may be specified via BODY." ;; These motions need wrapper functions to repeat correctly. (vimpulse-operator-map-define viper-end-of-Word 'inclusive) (vimpulse-operator-map-define viper-end-of-word 'inclusive) -(vimpulse-operator-map-define viper-find-char-backward 'inclusive) +(vimpulse-operator-map-define viper-find-char-backward 'exclusive) (vimpulse-operator-map-define viper-find-char-forward 'inclusive) (vimpulse-operator-map-define viper-forward-Word 'exclusive) (vimpulse-operator-map-define viper-forward-char 'inclusive) (vimpulse-operator-map-define viper-forward-word 'exclusive) -(vimpulse-operator-map-define viper-goto-char-backward 'inclusive) +(vimpulse-operator-map-define viper-goto-char-backward 'exclusive) (vimpulse-operator-map-define viper-goto-char-forward 'inclusive) (vimpulse-operator-map-define viper-search-backward 'exclusive) (vimpulse-operator-map-define viper-search-forward 'exclusive) -- 1.7.1.1
On Sun, Jul 25, 2010 at 1:33 AM, Tim Harper <[email protected]> wrote:
given: (this-is-some-text|)
dTe would result in:
(this-is-some-t|
dFe would result in
given: (this-is-some-|
This change resolves the issue by setting these operators to be exclusive, rather than incluse. --- vimpulse-operator.el | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vimpulse-operator.el b/vimpulse-operator.el index fd9acda..8c985bb 100644 --- a/vimpulse-operator.el +++ b/vimpulse-operator.el @@ -742,12 +742,12 @@ type TYPE. A custom function body may be specified via BODY." ;; These motions need wrapper functions to repeat correctly. (vimpulse-operator-map-define viper-end-of-Word 'inclusive) (vimpulse-operator-map-define viper-end-of-word 'inclusive) -(vimpulse-operator-map-define viper-find-char-backward 'inclusive) +(vimpulse-operator-map-define viper-find-char-backward 'exclusive) (vimpulse-operator-map-define viper-find-char-forward 'inclusive) (vimpulse-operator-map-define viper-forward-Word 'exclusive) (vimpulse-operator-map-define viper-forward-char 'inclusive) (vimpulse-operator-map-define viper-forward-word 'exclusive) -(vimpulse-operator-map-define viper-goto-char-backward 'inclusive) +(vimpulse-operator-map-define viper-goto-char-backward 'exclusive) (vimpulse-operator-map-define viper-goto-char-forward 'inclusive) (vimpulse-operator-map-define viper-search-backward 'exclusive) (vimpulse-operator-map-define viper-search-forward 'exclusive) -- 1.7.1.1
I'm wondering why any of these are 'inclusive'. I set them all to exclusive, and couldn't tell any difference. Inclusive is harmful for backward commands
Applied in commit [73bd005b58]. I did some minor formal changes to the commit message, like adding a period to the summary to make it consistent with the other commits. See also the new file CONTRIBUTE in the repository. :) -- Vegard
participants (2)
-
Tim Harper -
Vegard Øye