- implementations-list - lists.ourproject.org

[implementations-list] Re: vimpulse
by Alessandro Piras 01 Jul '09

01 Jul '09

Hi Fabian, I was looking at the viper source code to see how to add the '<,'> functionality to ex commands. It turns out it's quite boring to add it. Viper does not recognize the '< and '> marks, and the characters recognized as mark identifiers are hard coded in the ex command parser. I could easily change the parser to let it recognize '< '>, but that would be yet another viper function redefinition. I also think I'd have to change it in other places, like in the ' command, and god knows where else (as there are also other functions that check if the character is a valid mark, and it seems viper uses some sort of registers (the same code used for "a "b etc) to store markers. To avoid another redefinition, I can do 2 things: - put the line numbers that identify the current visual selection automatically after ":" - this would work almost the same, but then you would have to remember the line numbers if you want to issue a second command on the visual selection after it is turned off - use two marks, for example y and z, instead of < and >, and automatically put 'y,'z after the : when : is issued in visual mode. By the way, I'm forwarding this mail to the mailing list, so to hear other opinions too. I also invite you to subscribe to the mailing list, and direct your feature/fix requests there :) Cheers, Alessandro 2009/6/30 Fabian Braennstroem <f.braennstroem(a)gmx.de> > Hi Alessandro, > > Alessandro Piras wrote: > >> thanks for the suggestions! :) >> ex support is still bad in vimpulse, the code is at least 2 years old, and >> we didn't work much on it, but that will be on the schedule :) >> > > Sounds nice! I am quite happy, that I saw the new start ... somehow, I was > afraid, that it will stay at the current status (which was quite good) . > > Best Regards! > Fabian > > Ciao, >> Alessandro >> >> 2009/6/29 Fabian Braennstroem <f.braennstroem(a)gmx.de <mailto: >> f.braennstroem(a)gmx.de>> >> >> >> Hi Alessandro, >> >> thanks a lot! That is really great! >> One or two more suggestions I got, is the adjustment of the search >> using: >> set ignorecase >> set smartcase >> >> in vim and running commands on the visual region like: >> >> :'<,'>s/test/TEST/ >> >> in vim :-) >> >> Best Regards! >> Fabian >> >> Alessandro Piras wrote: >> >> Hi Fabian, >> unluckily, the emacs commands <do-something>-region don't work >> at all with the new visual selection, at least for the moment. >> I'll try to explain why. The region is the area between the mark >> and the point. there are quite a lot of functions that can be >> used to identify those two ends, I really don't know why. I >> tried at first to override region-beginning and region-end, and >> some command worked, and some didn't. I tried to override point >> and mark, and some other function worked, and some didn't. >> suffice is to say, there's no clean method to make those >> commands work automatically. There basically are 3 options: >> a) Move the mark and the point at the exit of visual mode, so to >> highlight the region. I really don't like this method at all >> b) Provide an explicit command to exit visual selection mode and >> activate the region, so you can use the region-related commands >> c) instead of using region-related commands, like comment-region >> and uncomment-region, you provide your own commands that operate >> on the visual selection (implemented using the region commands, >> possibly). >> >> I'll give you a quick solution using the method 3, as it's the >> one that I would use in that case :) >> >> (define-key viper-vi-global-user-map (kbd "\\\]") >> 'my-vimpulse-comment-region) >> (define-key viper-vi-global-user-map (kbd "\\,") >> 'my-vimpulse-uncomment-region) >> >> (defun my-vimpulse-comment-region () >> (interactive) >> (comment-region (vimpulse-get-vs-start) (vimpulse-get-vs-end)) >> (vimpulse-visual-mode nil)) >> >> (defun my-vimpulse-uncomment-region () >> (interactive) >> (uncomment-region (vimpulse-get-vs-start) (vimpulse-get-vs-end)) >> (vimpulse-visual-mode nil)) >> >> You can go further than this. As most (maybe all?) emacs region >> related commands have the syntax (command region-begin >> region-end), it's possible to convert commands in a more >> abstract way: >> (defmacro vimpulse-region-command (function) >> `(lambda () >> (interactive) >> (,function (vimpulse-get-vs-start) (vimpulse-get-vs-end)) >> (vimpulse-visual-mode nil))) >> (define-key vimpulse-vi-global-user-map "\\\]" >> (vimpulse-region-command comment-region)) >> (define-key vimpulse-vi-global-user-map "\\," >> (vimpulse-region-command uncomment-region)) >> >> As this macro seems to be of general interest, I'll add it to >> vimpulse's helper functions :) >> Thanks for your feedback! >> Alessandro >> >> >> >> >> 2009/6/28 Fabian Braennstroem <f.braennstroem(a)gmx.de >> <mailto:[email protected]> <mailto:[email protected] >> <mailto:[email protected]>>> >> >> >> Hi Alessandro, >> >> I just saw the new vimpulse release and that you took the >> maintaining :-) This is really great! I had to test the new >> release >> right away and like the new visual behavior. >> Right now, I got a short comment about the visual mode. I use >> quite >> a lot the command 'comment-region' to place comment characters >> in >> the first column of the whole visual region. This works with >> the new >> visual mode as well, but unfortunately it seems to behave in >> the old >> release style, which means that the last marked line does not >> get >> commented out!? >> >> (define-key viper-vi-global-user-map (kbd "\\\]") >> 'comment-region) >> (define-key viper-vi-global-user-map (kbd "\\,") >> 'uncomment-region) >> >> Do you have a hint, how to fix this? >> >> Thanks in advance! >> Fabian >> >> >> >> >> >

1 0

Re: [implementations-list] On the software design of a vi/vim core
by Marius Andersen 29 Jun '09

29 Jun '09

Jon, thanks for taking the time to share with us. Your scheme is very elegant; I particularly like how "motions" and "text objects" are seen as instances of a more general notion. I think the hardest part is keypress parsing. Simply binding keys like below won't do, as the second key binding will overwrite the first because it's more specific. That is, `daw' will work, but `dw' won't. (global-set-key "d" 'delete) ; reads motion (global-set-key "da" 'delete-an-object) ; reads text object Of course, we can solve this particular problem by modifying `delete' -- "if the next character is `a', then call `delete-an-object'", or some such. But this is a tedious approach. What we really want is an easy way to express the fact that it's possible to type d <motion> as well as d a <text object> so that when our next bright idea suggests itself, we can merrily break all vi conventions by adding d a æ <custom function> without having to rewrite `delete-an-object'. That is, we need some general representation (array, list) of what can follow what -- a "key grammar", if you will -- in place of the default approach of YAIE (Yet Another If Expression). (Viper has some scheme at its core, but it seems limited and the functions are littered with "special clauses" for things like macros etc. When I compare the comments with the actual code, I get the impression that Viper started off really beautiful and simple, but veered into complexity as the not-so-obvious complications of certain vi keys revealed themselves.) Any comments on this? Marius Andersen _________________________________________________________ Alt i ett. Få Yahoo! Mail med adressekartotek, kalender og notisblokk. http://no.mail.yahoo.com

2 1

Re: [implementations-list] Vimpulse update
by Marius Andersen 29 Jun '09

29 Jun '09

> Fra: Alessandro Piras <laynor(a)gmail.com> > Emne: Re: [implementations-list] Vimpulse update > Til: "Vi/Vim implementations list" <implementations-list(a)lists.ourproject.org> > Dato: Mandag 22. juni 2009 13.34 > > it's easy stuff actually :) It works like this: > I modified the viper-prefix-arg-com function to introduce 4 > new commands: da di ca ci. These commands will read-char to get motion > command. Yes, this is a very good way to do it. It means more objects can be easily added without any more mucking around in `viper-prefix-arg-com'. Anyway, I mailed Michael Kifer and asked if there was a way to avoid redefining `viper-prefix-arg-com', and he replied he couldn't think of one. So until the original function is redesigned, which will probably not happen any soon, I think we can hold on to the present approach. :) What now remains is copying commands, `yiw', `yas', etc., and visual commands like `viw' and `vas'. The former requires updating `viper-prefix-arg-com' with entries for `vimpulse-yi' and `vimpulse-ya', while the latter is just a matter of writing commands for moving the cursor. For example, `vas' moves the cursor one sentence forward if it's at the end of the selection, and one sentence backward if it's at the beginning. I think this illustrates another point, incidentally: the power of vi comes from the multitude of ways of combining very basic commands, but implementing those combinations requires lots and lots of code. Therefore I think building vimpulse.el on top on Viper, rather than implementing Vim emulation from scratch, is the better approach. Marius Andersen _________________________________________________________ Alt i ett. Få Yahoo! Mail med adressekartotek, kalender og notisblokk. http://no.mail.yahoo.com

3 4

[implementations-list] Where to report bugs (was: Vimpulse breaks inferior shells)
by Jason Spiro 24 Jun '09

24 Jun '09

On Wed, Jun 24, 2009 at 10:43 AM, Alessandro Piras<laynor(a)gmail.com> wrote: > Also, please report the bugs on the mailing list, not directly to me, thanks Not at http://my-trac.assembla.com/vimpulse/report/1 ? :-)

2 1

[implementations-list] When and how to check code into SVN (was: text objects)
by Jason Spiro 24 Jun '09

24 Jun '09

On Wed, Jun 24, 2009 at 2:56 PM, Alessandro Piras <laynor(a)gmail.com> wrote: > I will switch to version 0.3.0 when I'll get repeatable visual commands XD > I'm also thinking about improving visual block mode, and refactor the code a > little ^^ > Actually, I'm already working on a multiple file version, I split the code > into several files hat should contain more or less separate functionalities, > as navigating thru a big file usually bothers me quite a lot, especially > when there are huge functions like the redefinition of viper-prefix-arg-com. > Anyway, it's still possible to redistribute vimpulse as one big file, and > there's a ready Makefile that does the job. > What do you think? better to upload the split file version now or when I'm > done with the visual command repetition stuff? It doesn't matter when you check the split file version into SVN. But it's best if the splitting checkin doesn't involve any code changes; make all code changes in a separate checkin. By the way, have you been bumping the version number and making a new release on EmacsWiki every time you checked in code? You don't have to. You can make a release just every few weeks or so. Also, it's possible to set things up so that a mail goes to the mailing list every time you make an SVN checkin. BTW I like that the version vimpulse.el on EmacsWiki is one big file I can simply download and install :) Cheers, -Jason

2 2

[implementations-list] There are dozens of other Vi/Vim implementations (was: Maciej's from-scratch Vim emulation project)
by Jason Spiro 24 Jun '09

24 Jun '09

On Mon, Jun 22, 2009 at 4:37 PM, Jason Spiro <jasonspiro3(a)gmail.com> wrote: ... > Hi Maciej, > > I was discussing other vi clones for Emacs with Alessandro over Gtalk > today. I mentioned John J. Foerch's http://jjfoerch.com/modal-mode/ > and your project. Dear list: Note that there are dozens of other Vi and Vim clones and implementations. There's a list of them at http://texteditors.org/cgi-bin/wiki.pl?ViFamily ; six different ones on the list work inside Emacs. (Look next to where the page mentions Vimpulse.)

1 0

[implementations-list] text objects
by Alessandro Piras 24 Jun '09

24 Jun '09

I noticed the code for text objects in the current version is bug-ridden. I've corrected it and it will be in svn in a short time. Also, you could have noticed text object related commands (namely, da, di, ca, ci) can't be repeated with a dot, and count is not taken into account (2daw only deletes one word, for example). This will be over by tomorrow, and you will have well integrated text object commands :) Stay tuned. Alessandro

2 4

[implementations-list] Avoiding getting bug reports by email (was: Vimpulse breaks inferior shells)
by Jason Spiro 24 Jun '09

24 Jun '09

On Wed, Jun 24, 2009 at 9:43 AM, Alessandro Piras <laynor(a)gmail.com> wrote: > Also, please report the bugs on the mailing list, not directly to me, thanks > ! > Alessandro If you want to avoid getting bug reports by private mail, one thing to try is to make sure your email address doesn't appear anywhere in the first fifty lines or so of vimpulse.el, and to put in the list email address (best obfuscated like implementations-list at lists.ourproject.org) and website instead :-) Cheers, Jason

1 0

[implementations-list] Re: Vimpulse breaks inferior shells
by Alessandro Piras 24 Jun '09

24 Jun '09

Also, please report the bugs on the mailing list, not directly to me, thanks ! Alessandro 2009/6/24 Alessandro Piras <laynor(a)gmail.com> > Hi menno, and thanks for your report. > The problem resides in the RET binding, I didn't know it could cause > problems. > Search for the line > (define-key viper-insert-global-user-map (kbd "RET") > 'vimpulse-enter-indents) > and comment it, your problem will be gone, but you will lose automatic > indenting when pressing enter. > I will try to find a solution :) > Cheers, > Alessandro > > > 2009/6/24 Menno <menno(a)freshfoo.com> > > Hi, >> >> Firstly, thanks for maintaining Vimpulse. It is part of the reason I made >> the switch from Vim to Emacs. >> >> I've been using Vimpulse 0.2.6.3 for a while and yesterday tried out >> 0.2.6.8 (and 0.2.6.9 today). With the new versions, inferior shells (eg. >> shell or sql-postgres) have stopped working. I get a prompt, can enter a >> command but I never see output. >> >> The problem is definitely related to Vimpulse. If I revert to the older >> version the problem goes away. >> >> Any ideas? >> >> Thanks, >> Menno >> > >

1 0

[implementations-list] Making sure undo works properly (was: About bugs)
by Jason Spiro 23 Jun '09

23 Jun '09

On Tue, Jun 23, 2009 at 1:52 AM, Alessandro Piras <laynor(a)gmail.com> wrote: > Dear users and contributors, > I had the feeling these days that undos don't work properly. I was almost > sure it sucked big time on certain occasions, but in this last hour I was > trying to reproduce the bad behavior and everything worked properly. > If you find undo behaving in a non-natural way, please report it here on the > mailing list, with proper instructions to reproduce the bad behavior. > Thank you, > Alessandro. Will do. By the way, know that you can M-x view-lossage to print the last 100 keystrokes. Or, if you want to record all your input into a file, M-x open-dribble-file. Both keep track all types of keystrokes, including special keys and key combinations.

1 0