[TENTATIVE PATCH] Digraph implementation for Evil

Vegard Øye vegard_oye at hotmail.com
Mon May 23 23:30:33 CEST 2011


On 2011-05-23 17:10 +0200, Nikolai Weibull wrote:

> On Sun, May 22, 2011 at 12:34, Vegard Øye wrote:
>
>> Do you want digraph.el to be part of Evil, or do you want to
>> distribute it as a standalone library?
>
> I hereby place it in the public domain, so please add it as
> evil-digraphs.el. You may make any modifications you deem
> necessary, like removing the unneeded function digraph-read.

Done in commit cacedaf. :)

> I’d love to see my name in some AUTHORS or CONTRIBUTORS file,
> though :-).

Of course! We hadn't really thought of that yet, but commit 2aa19af
adds a comment header to evil.el.

> The tests ran really slow on my computer (around 1.5 minutes).
> Any way of speeding them up?

That's strange; on my not-so-recent Ubuntu machine, "time make test"
clocks in at roughly 12 seconds. What's your system and Emacs version?

>> I haven't handled merge requests on Gitorious before; the common
>> approach has been to commit the changes locally, export the commit
>> with "git format-patch", and post the patch on the mailing list.
>
> OK, I’ll do that in the future.

Actually, just continue doing things via Gitorious. That takes some
load off the mailing list.

-- 
Vegard



More information about the implementations-list mailing list