May 2010 - implementations-list - lists.ourproject.org

[implementations-list] [Vimpulse] Bug: something's worng when pasting whole lines:
by Alessandro Piras 19 May '10

19 May '10

;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. If the cursor is at the beginning of the buffer and for example I do jVjyP the result is ;; This buffer is for notes you don't want to save, and for Lisp evaluation. ;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer.;; If you want to create a file, visit that file with C-x C-f, ;; then enter the text in that file's own buffer. Alessandro Piras

4 10

[implementations-list] [vimpulse/viper] bug: ~ (tilde) doesn't forward char after changing the case of the character at point.
by Alessandro Piras 18 May '10

18 May '10

no need for further explanations i guess

2 2

[implementations-list] [Vimpulse] bug(?): vimpulse breaks dired-x
by Alessandro Piras 15 May '10

15 May '10

Something in vimpulse or its dependencies clashes with dired-x: This is what happens when I (require 'dired-x) if vimpulse is loaded: Is vimpulse remapping M-o? ebugger entered--Lisp error: (error "Key sequence M-o starts with non-prefix key ") define-key((keymap #^[nil nil keymap #^^[3 0 nil nil nil nil nil nil nil nil viper-backward-char nil bookmarkp-dired-jump-current nil nil dired-find-file viper-next-line dired-display-file viper-previous-line nil nil nil ... nil nil nil ... nil nil viper-intercept-ESC-key nil nil nil nil viper-forward-char dired-do-shell-command nil dired-flag-auto-save-files dired-hide-subdir ... dired-do-async-shell-command nil nil nil ... dired-create-directory nil negative-argument dired-clean-directory nil ...] #^^[1 0 #^^[2 0 #^^[3 0 nil nil nil nil nil nil nil nil viper-backward-char nil bookmarkp-dired-jump-current nil nil dired-find-file viper-next-line dired-display-file viper-previous-line nil nil nil ... nil nil nil ... nil nil viper-intercept-ESC-key nil nil nil nil viper-forward-char dired-do-shell-command nil dired-flag-auto-save-files dired-hide-subdir ... dired-do-async-shell-command nil nil nil ... dired-create-directory nil negative-argument dired-clean-directory nil ...] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil] nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil ...] (backspace . viper-backward-char) (menu-bar keymap (operate "Operate" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Operate") (mark "Mark" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Mark") (regexp "Regexp" keymap ... ... ... ... ... ... ... ... ... ... ... "Regexp") (immediate "Immediate" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... ... "Immediate") (subdir "Subdir" keymap ... ... ... ... ... ... ... ... ... ... ... ... ... "Subdir")) (up . dired-previous-line) (down . dired-next-line) (follow-link . mouse-face) (mouse-2 . dired-mouse-find-file-other-window) (remap keymap (vimpulse-visual-insert . viper-nil) (vimpulse-visual-append . viper-nil) (vimpulse-delete . viper-nil) (vimpulse-change . viper-nil) (viper-substitute-line . viper-nil) (viper-substitute . viper-nil) (viper-kill-line . viper-nil) (viper-insert . viper-nil) (viper-command-argument . viper-nil) (viper-change-to-eol . viper-nil) (viper-append . viper-nil) (viper-Insert . viper-nil) (viper-Append . viper-nil) (advertised-undo . dired-undo) (undo . dired-undo) (self-insert-command . undefined))) "\357" dired-omit-mode) byte-code("\306 \307\310#\210\306 \311\312#\210\306 \313\314#\210\306 \315\314#\210\306 \316\317#\210\306 \320\321#\210\306 \322\323#\210\306 \324\325#\210\306 \326\327#\210\306 \330\331#\210\306 \332\333#\210\306 \334\335#\210 \203R Alessandro Piras

2 1

[implementations-list] Reading commit 1b34d16a226
by Štěpán Němec 15 May '10

15 May '10

+ (when (< 23.2 (progn (string-match "^[0-9]+\\.[0-9]+" + emacs-version) + (string-to-number + (match-string 0 emacs-version)))) Why not (version< "23.2" emacs-version) instead of the clumsy matching and type conversion? (Just don't ask what the `version<' function does internally ;-).) (Not mentioning the fact that your + ;; Restore dabbrev variables if version < 23.2 comment suggests the exact opposite of what the code actually does.)

2 10

[implementations-list] [PATCH] Define a proper prefix command for the "\C-w" map.
by Štěpán Němec 12 May '10

12 May '10

This makes customization and rebinding possible. --- Example (why I felt the need): Now I can (eval-after-load 'vimpulse '(define-key term-raw-escape-map "\C-w" 'vimpulse-window-map)) to be able to use Vimpulse window bindings in Emacs' term modes. vimpulse-misc-keybindings.el | 23 ++++++++++++----------- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/vimpulse-misc-keybindings.el b/vimpulse-misc-keybindings.el index 3a6c723..49f25d9 100644 --- a/vimpulse-misc-keybindings.el +++ b/vimpulse-misc-keybindings.el @@ -64,19 +64,20 @@ (define-key viper-vi-basic-map "\C-r" 'redo))) ;; Window manipulation -(define-key viper-vi-basic-map "\C-w" (make-sparse-keymap)) -(define-key viper-vi-basic-map "\C-w\C-w" 'vimpulse-cycle-windows) -(define-key viper-vi-basic-map "\C-ww" 'vimpulse-cycle-windows) -(define-key viper-vi-basic-map "\C-wo" 'delete-other-windows) -(define-key viper-vi-basic-map "\C-wc" 'delete-window) -(define-key viper-vi-basic-map "\C-ws" 'split-window-vertically) -(define-key viper-vi-basic-map "\C-wv" 'split-window-horizontally) +(define-prefix-command 'vimpulse-window-map) +(define-key viper-vi-basic-map "\C-w" 'vimpulse-window-map) +(define-key vimpulse-window-map "\C-w" 'vimpulse-cycle-windows) +(define-key vimpulse-window-map "w" 'vimpulse-cycle-windows) +(define-key vimpulse-window-map "o" 'delete-other-windows) +(define-key vimpulse-window-map "c" 'delete-window) +(define-key vimpulse-window-map "s" 'split-window-vertically) +(define-key vimpulse-window-map "v" 'split-window-horizontally) (when (fboundp 'windmove-left) - (define-key viper-vi-basic-map "\C-wh" 'windmove-left) - (define-key viper-vi-basic-map "\C-wj" 'windmove-down) - (define-key viper-vi-basic-map "\C-wk" 'windmove-up) - (define-key viper-vi-basic-map "\C-wl" 'windmove-right)) + (define-key vimpulse-window-map "h" 'windmove-left) + (define-key vimpulse-window-map "j" 'windmove-down) + (define-key vimpulse-window-map "k" 'windmove-up) + (define-key vimpulse-window-map "l" 'windmove-right)) ;;; Insert mode keys -- 1.7.1

2 1

[implementations-list] [PATCH] Sanitize the folding setup.
by Štěpán Němec 12 May '10

12 May '10

Don't force `global-reveal-mode' upon users; this unbreaks at least Org and Allout modes. When we're at it, also - don't use anonymous functions in hooks and key bindings (this sloppy practice should stay limited to user code) - fix erroneous customize type of `vimpulse-fold-level' - remove unused `vimpulse-hs-Open' definition - don't call `hs-hide-all' interactively (makes no sense) --- This patch doesn't improve the existing folding functionality, only prevents it from breaking other Emacs modes. I don't use Vimpulse folding, but testing didn't suggest any breakage there (unless you consider preventing somewhat undeterministic behaviour with Reveal mode on all the time a breakage). vimpulse-compatibility.el | 39 +++++++++++---------------------------- vimpulse-dependencies.el | 2 +- 2 files changed, 12 insertions(+), 29 deletions(-) diff --git a/vimpulse-compatibility.el b/vimpulse-compatibility.el index e40ceb3..210927f 100644 --- a/vimpulse-compatibility.el +++ b/vimpulse-compatibility.el @@ -279,36 +279,19 @@ Disable anyway if FORCE is t." ;;; Folding -;; Almost all of this code is taken from extended-viper -;; coded by Brad Beveridge (bradbev at gmail.com) -;; - I changed the prefix of the custom functions to `vimpulse' -;; to avoid multiple prefixes (eval-after-load 'hideshow '(progn - (defun vimpulse-hs-Open () + (defun vimpulse-za () (interactive) - (hs-show-block) - (hs-hide-level -1)) - (add-hook 'hs-minor-mode-hook - (lambda () - (call-interactively 'hs-hide-all) - (define-key viper-vi-basic-map "za" - (lambda () - (interactive) - (hs-toggle-hiding) - (hs-hide-level vimpulse-fold-level))) - (define-key viper-vi-basic-map "za" 'hs-toggle-hiding) - (define-key viper-vi-basic-map "zm" 'hs-hide-all) - (define-key viper-vi-basic-map "zr" 'hs-show-all) - (define-key viper-vi-basic-map "zo" 'hs-show-block) - (define-key viper-vi-basic-map "zc" 'hs-hide-block))))) - -;; Load reveal.el if available -(unless (featurep 'reveal) - (condition-case nil - (require 'reveal) - (error nil))) -(when (fboundp 'global-reveal-mode) - (global-reveal-mode 1)) + (hs-toggle-hiding) + (hs-hide-level vimpulse-fold-level)) + (defun vimpulse-hs-setup () + (hs-hide-all) + (define-key viper-vi-basic-map "za" 'vimpulse-za) + (define-key viper-vi-basic-map "zm" 'hs-hide-all) + (define-key viper-vi-basic-map "zr" 'hs-show-all) + (define-key viper-vi-basic-map "zo" 'hs-show-block) + (define-key viper-vi-basic-map "zc" 'hs-hide-block)) + (add-hook 'hs-minor-mode-hook 'vimpulse-hs-setup))) (provide 'vimpulse-compatibility) diff --git a/vimpulse-dependencies.el b/vimpulse-dependencies.el index db90644..f37a2ec 100644 --- a/vimpulse-dependencies.el +++ b/vimpulse-dependencies.el @@ -102,7 +102,7 @@ Off by default." (defcustom vimpulse-fold-level 0 "Default fold level." - :type 'boolean + :type 'integer :group 'vimpulse) ;; The secrets discovered from untold diggings among -- 1.7.1

2 1

[implementations-list] Broken selection in latest Vimpulse (r199)?
by Štěpán Němec 03 May '10

03 May '10

Hello, I vimdiffed yesterday (after not having updated for some time) to the latest Vimpulse as of revision 199 (and I swore I won't do that again -- I'm going to just use git-svn in the future ;-|), and visual mode exhibits the following bug for me: When I select some text, just pressing `d' or `y' does not execute the corresponding actions any more -- it seems to be waiting for another key (and indeed, after pressing another key, the action is executed). It seems to be too obviously broken (actually I seem to be observing more bugs, but this is the most clear and deterministic one) for me to believe that you haven't noticed, but I still figured I'd ask before trying to investigate myself. Thanks and best regards, Štěpán

2 9