[implementations-list] Reading commit 1b34d16a226

Vegard Øye vegard_oye at hotmail.com
Sun May 9 21:42:25 CEST 2010


> Date: Sun, 9 May 2010 20:40:36 +0200
> From: stepnem at gmail.com
>
> I still see the same old contradiction -- the code does (roughly)
> the same, and you didn't change the comment in that commit either.

Duh! I have a habit of writing the value to be compared against first,
but <'s "less than" moniker presupposes the opposite order. I.e.,

    (= 2 x) ; is x equal to 2?
    (< x 2) ; is x less than 2?

The comment, which uses infix notation, has it right.

(The reason I prefer the first order is I find it more readable when a
complicated expression is substituted for x. Compare

    (= 2 (wibble
          (wobble (flob))))

with

    (= (wibble
        (wobble (flob))) 2)

or

    (= (wibble
        (wobble (flob)))
       2)

It is more readable to present the simplest expression first, and the
simplest expression is usually the one we compare against.)

Well, commit [5c7c7193ca] should set things right.

Vegard 		 	   		  
_________________________________________________________________
Få nye Windows Live™ Messenger.
http://download.live.com/messenger


More information about the implementations-list mailing list