[implementations-list] Why can't I byte-compile (all of) Vimpulse?

[Štěpán Němec]

> There is a question I wanted to ask since a few revisions ago -- it's
> nothing really important, I'm just curious about it. The fact is that
> whenever I try to compile at least one of the following:
> 
>         * vimpulse-modal.el
>         * vimpulse-operator.el
>         * vimpulse-text-object-system.el
>         * vimpulse-visual-mode.el
> 
> the  whole Vimpulse stops working correctly. Of course, compiling the
> bundle (vimpulse_big.el) doesn't work either. My question is: is this
> normal, or is it just me? Do you guys byte-compile Vimpulse at all?

Haha, obviously nobody does...

I'm attaching a patch that fixes some of the trivial problems spotted by
the byte-compiler (including typos). Some of the others are benign, and
for the rest, deeper understanding of the code is needed (which I don't
have):

1.
vimpulse-modal.el:338:8:Error: Wrong type argument: integer-or-marker-p,
key-vector

Here the problem is clear -- `kbd' is a macro, so it's not gonna work
compiled like that. Some refactoring is needed.

2.
vimpulse-operator.el:464:16:Warning: reference to free variable
`operator'

The `vimpulse-operator-repeat' function definition seems to be broken,
but not obviously enough for me to know how to fix it.


There might be other problems -- I wondered once about byte-compiling,
too, noticing some of the macros, defadvices, eval-after-loads etc., but
we'll see after the basic ones are fixed (or maybe Vegard knows better
already).


Štěpán
-------------- next part --------------