Evil commit 6841 doesn't work for mark-defun
Hi Vegard, I just noticed that your commit 6841 works perfectly for marking paragraph but not for `mark-defun'. York
After commit 33b43f8, "C-M-h" should work properly in c/c++-mode. -- Vegard
Hi Vegard, Thanks for the fixes. They all seem to work exccept that `mark-defun' and `c-mark-defun' do not work. When I start emacs without evil, I press "C-M-h" and the current function is selected, pressing "C-M-h" again the following function is selected, pressing again will selecte the third one etc. But if evil is loaded, even in Emacs State, I can only have the current function selected, the selection would not expand when I press "C-M-h" again. The problem is exactly the same as that "M-h" doesn't expand the selection of current paragraph before your earlier fix. However, the fix for "M-h" apparently doesn't work for "C-M-h" and I actually had already tried that approach before posting the problem here. Thanks, York On Fri, Aug 5, 2011 at 12:56 PM, Vegard Øye <[email protected]> wrote: After commit 33b43f8, "C-M-h" should work properly in c/c++-mode. -- Vegard _______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2011-08-08 16:57 +0200, York Zhao wrote:
When I start emacs without evil, I press "C-M-h" and the current function is selected, pressing "C-M-h" again the following function is selected, pressing again will selecte the third one etc. But if evil is loaded, even in Emacs State, I can only have the current function selected, the selection would not expand when I press "C-M-h" again.
Commit fba5e8e removes `mark-defun' et al. from `evil-motions' and adjusts Evil's region behavior. If this doesn't fix the problem, then please start a fresh instance of Emacs by running "make emacs" in Evil's directory and reproduce the bug there. It would also help if you could provide an excerpt of the actual code (functions) that you are selecting with "C-M-h". (It's rather strange that you are seeing the same behavior in Emacs state. I would appreciate more details, as I am unable to reproduce this myself.) -- Vegard
Hi Vegard, I appreciate your work on this and yes the "make emacs" worked for this. And I then noticed that both `mark-defun' and `c-mark-defun' have been adviced by senator (in Cedet). I have tested without loading cedet and it worked fine. I also tested loading cedet without evil and it still doesn't work, so apparently the problem is caused by cedet not evil. Sorry about that. Thanks, York On Mon, Aug 8, 2011 at 6:00 PM, Vegard Øye <[email protected]> wrote: On 2011-08-08 16:57 +0200, York Zhao wrote:
When I start emacs without evil, I press "C-M-h" and the current function is selected, pressing "C-M-h" again the following function is selected, pressing again will selecte the third one etc. But if evil is loaded, even in Emacs State, I can only have the current function selected, the selection would not expand when I press "C-M-h" again.
Commit fba5e8e removes `mark-defun' et al. from `evil-motions' and adjusts Evil's region behavior. If this doesn't fix the problem, then please start a fresh instance of Emacs by running "make emacs" in Evil's directory and reproduce the bug there. It would also help if you could provide an excerpt of the actual code (functions) that you are selecting with "C-M-h". (It's rather strange that you are seeing the same behavior in Emacs state. I would appreciate more details, as I am unable to reproduce this myself.) -- Vegard _______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2011-08-09 17:34 +0200, York Zhao wrote:
On Mon, Aug 8, 2011 at 6:00 PM, Vegard Øye wrote:
It's rather strange that you are seeing the same behavior in Emacs state. I would appreciate more details, as I am unable to reproduce this myself.
I appreciate your work on this and yes the "make emacs" worked for this. And I then noticed that both `mark-defun' and `c-mark-defun' have been adviced by senator (in Cedet). I have tested without loading cedet and it worked fine. I also tested loading cedet without evil and it still doesn't work, so apparently the problem is caused by cedet not evil. Sorry about that.
There were some small quirks in Evil's handling of things as well, so it's all for the better. Selection commands like `mark-defun' should now work properly without being listed in `evil-motions'. -- Vegard
participants (2)
-
Vegard Øye -
York Zhao