On Tue, Feb 09, 2010 at 02:57:08PM +0000, Vegard Øye wrote:
We are approaching release. Has anyone tried the latest revisions?
Yeah, I just updated to the latest (special thanks for Emacs-compatible rectangles). Two minor nits I noticed (line numbers corresponding to vimpulse-big.el): l. 1686: ;; Eldoc compatibility (eval-after-load 'eldoc '(let (cmd) (dolist (cmd (append vimpulse-viper-movement-cmds vimpulse-core-movement-cmds)) (eldoc-add-command cmd)))) If you look at `eldoc-add-command', you see it takes (&rest cmds), so it does exactly what you need (i.e. simply something like (eldoc-add-command (append vimpulse-...)) would make more sense (I also don't see the point of wrapping `let' around `dolist', am I missing something?)). l. 1717: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;;;;;;;;;;;; VISUAL MODE BINDINGS ;;;;;;;;;;;;;;;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; (define-key viper-vi-basic-map "v" 'vimpulse-visual-mode) (define-key viper-vi-basic-map "V" 'vimpulse-visual-mode-linewise) This should be deleted, as you redefine "v" and "V" later anyway, and the following has nothing to do with Visual mode. Štěpán