On Thu, Apr 15, 2010 at 12:49:21PM +0000, Vegard Øye wrote:
Date: Wed, 14 Apr 2010 23:40:18 +0200 From: [email protected]
Any tips on making that function shorter?
(defun vimpulse-operator-message ...)
That's a great improvement -- from 50 lines to 34, through clever use of the `apply' form. I've modified it a little (in changeset [2c87f791af]) so that the block message reads "1 row and 4 columns", rather than the cryptic "1×4 characters".
I am /not/ including them in Vimpulse's Acknowledgements :P
Heh, oh well... It was more or less a joke, you know. If I was serious, I would send in a proper patch -- we have Git now! But I'm glad it did provide some inspiration ;-) Štěpán P.S.: In your original function, I noticed the use of U+00D7 MULTIPLICATION SIGN, which I intentionally replaced with 'x' in my version. Now it's gone for good, but in general I'd recommend against using non-ascii characters in the code, unless necessary. ...oh, and "changeset" is Hg-speak, in Git it's "commit" :P