[kune-commits] Review Request 7: Fix for #442: Invitations should allow multilines and carriadge return
Vicente J. Ruiz Jurado
vjrj at ourproject.org
Tue Jan 29 18:25:16 CET 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.comunes.org/r/7/#review1
-----------------------------------------------------------
Ship it!
LGTM
- Vicente J. Ruiz Jurado
On Jan. 27, 2013, 11:17 p.m., samer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.comunes.org/r/7/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2013, 11:17 p.m.)
>
>
> Review request for kune and Vicente J. Ruiz Jurado.
>
>
> Description
> -------
>
> Fix for issue #442
>
> I guess for these easy changes we dont need review request, but I want to test the review board.
>
> PS: This fix worsens the current bug #493 (as the regex includes more than just space)
>
>
> Diffs
> -----
>
> src/main/java/cc/kune/common/shared/utils/TextUtils.java aa3527111924f3213ec02d1135ffccd9c628fd5f
> src/main/java/cc/kune/core/client/invitation/AbstractInvitateAction.java 015e28f9353553bcf0f5e14e3b533de21d871ae1
> src/test/java/cc/kune/common/shared/utils/TextUtilsTest.java 299a568b9ebe7903a3c22d76feb09a1328805f70
>
> Diff: http://reviews.comunes.org/r/7/diff/
>
>
> Testing
> -------
>
> Ran unit tests
> Tested manually on local server
>
>
> Thanks,
>
> samer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ourproject.org/pipermail/kune-commits/attachments/20130129/ff17a79d/attachment.htm
More information about the kune-commits
mailing list