evil not entering emacs-state in magit-key-mode even if magit-key-mode is listed in evil-emacs-state-modes

[Frank Fischer]

On 2012-11-07, Sanel Zukan <sanelz at gmail.com> wrote:
> Just recompiled emacs 24.2. The same behaviour.

I still do not have the behavior.
Can you bisect to determine which commit caused the problem?

And maybe try the patch I posted somewhere else today:

==========
 (defadvice evil-mode-check-buffers (before start-evil activate)
   "Determine the initial state."
   (dolist (buffer evil-mode-buffers)
-    (when (buffer-live-p buffer)
+    (when (and (buffer-live-p buffer)
+               (not (minibufferp)))
       (with-current-buffer buffer
         (evil-initialize-state)))))
==========

I just want to make sure that evil is not initialized in the
minibuffer. (You can also check whether evil is active in the
minibuffer: after typing : first type i then q!. If this works then
evil is active in the minibuffer although it should not be).

Frank
					   

>
> Regards,
> Sanel
>
> On Wed, Nov 7, 2012 at 4:19 PM, Sanel Zukan <sanelz at gmail.com> wrote:
>> I'm using Emacs 24.1.1 on Fedora 17. I did started it as you
>> suggested, and done this:
>>
>> 1. opened client with 'emacsclient -t'
>> 2. open file (:e ~/foo)
>> 3. tried to do :q! but when I hit 'q', I'm getting: Defining kbd macro...
>>
>> After this, everything gets messed up, even 'M-x' doesn't work (tried
>> M-x 'emacs-version'
>> but after hitting 'e' I got 'End of buffer').
>>
>> This is always reproducible.
>>
>> Regards,
>> Sanel
>>
>> On Wed, Nov 7, 2012 at 3:46 PM, Frank Fischer
>> <frank-fischer at shadow-soft.de> wrote:
>>> On 2012-11-07, Sanel Zukan <sanelz at gmail.com> wrote:
>>>> I'm not sure was the cause this commit or one of before, but after I
>>>> pulled latest code
>>>> my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work.
>>>>
>>>> I described this in:
>>>> https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-mode
>>>>
>>>> Anyone with the same issue?
>>>>
>>>
>>>
>>> I can't reproduce that. Which emacs version do you use? What happens
>>> if you start the server in evil's source directory with
>>>
>>> emacs -Q -L . -l evil.el --eval "(evil-mode 1)" --daemon
>>>
>>> (this loads nothing but evil)?
>>>
>>> Frank
>>>
>>>
>>> _______________________________________________
>>> implementations-list mailing list
>>> implementations-list at lists.ourproject.org
>>> https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list


-- 
Frank Fischer
Chemnitz University of Technology, Department of Mathematics
eMail: frank.fischer at mathematik.tu-chemnitz.de
Tel.: +49 (371) 531-36913