evil not entering emacs-state in magit-key-mode even if magit-key-mode is listed in evil-emacs-state-modes

Wed Nov 7 13:47:44 CET 2012

On 2012-11-07, Alessandro Piras <laynor at gmail.com> wrote:
> Hi, thanks for the fix!
> Now magit works correctly without my advice, but there is another problem:
> When doing C-x C-f with ido mode activated, it comes up in normal state!
> Adding minibuffer-inactive-mode to evil-emacs-state-modes seems to solve
> the issue.

Hm, currently evil should not be activated in any minibuffer. Seems as
if the latest work on the initialization code causes this bug. Can you
please check if the following change fixes this bug? (I doesn't seem
to occur with my emacs version).


==========
diff -r cfd40950b001 evil-core.el

--- a/evil-core.el	Tue Nov 06 14:20:08 2012 +0100
+++ b/evil-core.el	Wed Nov 07 13:44:59 2012 +0100
@@ -286,7 +286,8 @@
 (defadvice evil-mode-check-buffers (before start-evil activate)
   "Determine the initial state."
   (dolist (buffer evil-mode-buffers)
-    (when (buffer-live-p buffer)
+    (when (and (buffer-live-p buffer)
+               (not (minibufferp)))
       (with-current-buffer buffer
         (evil-initialize-state)))))
==========

Best regards,
Frank



