[implementations-list] [PATCH] Remove unused undo-list-munging code.
stepnem at gmail.com
Fri May 21 22:42:42 CEST 2010
On Fri, May 21, 2010 at 08:22:22PM +0000, Vegard Øye wrote:
> > While looking at the code, I noticed that all of this is currently
> > unused. Is that just an oversight, or are you actually planning to
> > use it in the future?
> The purpose of `vimpulse-connect-undos' is to collapse a single "edit"
> like "cwfoo" to a single undo. Right now it's more fine-grained:
> "cwfoo<Esc>u" undos to the insertion of "foo", so that another "u" is
> needed to undo the deletion of the original word.
Well, the purpose is clear, it's just that the code is not used
> The reason this code lies dormant is that although it's relevant, I'm
> unsure how it goes together with undo-tree.el.
Yeah. I'm unsure even about how adding `vimpulse' to buffer-undo-list
goes together with standard Emacs undo. Maybe Frank could comment -- I
assume the original code comes from him?
P.S.: Maybe you could at least add a code comment in similar cases? Am I
the only one who finds it weird to have unused code lying around like
More information about the implementations-list