[implementations-list] Reading commit 1b34d16a226

Štěpán Němec stepnem at gmail.com
Sun May 9 19:36:16 CEST 2010

+               (when (< 23.2 (progn (string-match "^[0-9]+\\.[0-9]+"
+                                                  emacs-version)
+                                    (string-to-number
+                                     (match-string 0 emacs-version))))

Why not (version< "23.2" emacs-version) instead of the clumsy
matching and type conversion? (Just don't ask what the `version<'
function does internally ;-).)
(Not mentioning the fact that your

+      ;; Restore dabbrev variables if version < 23.2

comment suggests the exact opposite of what the code actually does.)

More information about the implementations-list mailing list