[PATCH/RFC] Add some tips for contributors.
stepnem at gmail.com
Fri Jul 23 14:20:59 CEST 2010
Vegard Øye <vegard_oye at hotmail.com> writes:
> On 2010-07-23 13:27, Štěpán Němec wrote:
>> Committing people's patches edited is a no no. At least I strongly
>> prefer having a discussion and resending the patch, possibly several
>> times, to having my patch edited (and possibly borken, which seems
>> to have happened with 9b9c0298530) and committed under my name. Or
>> being asked "I'll commit this instead/squash these changes in, OK?".
> (But how is commit [9b9c0298530] "borken"? All I did was to reformat
> the comment + add a period to the commit summary.)
What I see in `git log' output for that commit is a single huge line
instead of the normally formatted paragraph I see in Tim's message (and
no blank line between summary and the message proper).
More information about the implementations-list