For hideshow mode, don't hide all lines by default

Štěpán Němec stepnem at
Sun Jul 11 21:45:17 CEST 2010

commit dbf7305dbde4737d73748ae31e724e722ef0ce34
Author: Stephen Bach <git at>
Date:   Fri Jul 9 13:44:46 2010 -0400

    For hideshow mode, don't hide all lines by default
 vimpulse-compatibility.el |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/vimpulse-compatibility.el b/vimpulse-compatibility.el
index c2c59f0..9d0adae 100644
--- a/vimpulse-compatibility.el
+++ b/vimpulse-compatibility.el
@@ -294,7 +294,6 @@ (eval-after-load 'hideshow
        (hs-hide-level vimpulse-fold-level))
      (defun vimpulse-hs-setup ()
-       (hs-hide-all)
        (define-key viper-vi-basic-map "za" 'vimpulse-za)
        (define-key viper-vi-basic-map "zm" 'hs-hide-all)
        (define-key viper-vi-basic-map "zr" 'hs-show-all)

Why? Isn't that what Vim does, when you turn folding on? (It would have
been nice to have the rationale in the commit message, providing there
is one).

I don't use hs-minor-mode, but a possible reason for this change I can
think of is that it breaks existing Emacs user expectations, because the
mode hook triggers the hiding unconditionally. Is that it?


P.S.: Up to 99fb1aaa1e5, commit summaries end with a period. Then there
are four commits without and one with a period again. Just felt like
mentioning that. >_>

More information about the implementations-list mailing list