[implementations-list] Re: Re: [PATCH] Vimpulse: vi* and va* object selection implementation proposal

José A. Romero L. escherdragon at gmail.com
Sun Nov 22 19:01:21 CET 2009


Hi Jason,

2009/11/22  <implementations-list-request at lists.ourproject.org>:
(...)
> *  Next time you write a patch, write [PATCH] in the subject line.  I
> have done this for you now.

Sure will, thanks.

> *  There's no need to attach all of Vimpulse -- just the .patch file.
> That is why your mail was automatically held until I approved it:
> your mail exceeded I think 128K.

I  see.  When  considering a patch I usually like to examine both the
patch itself and the modified code, to see how it "merges"  with  the
rest. But sure, next time I will attach only the patch.

> Now some questions:
>
> 1.  Do you agree that when Vimpulse finally gets into Emacs, you will
> be able to mail or fax in a copyright assignment saying that your work
> will no longer be copyrighted by you but by the FSF?  Can you please
> private-mail to me and Alessandro your phone number and either your
> home or work snail mail address?  We don't plan to use it except for
> asking you for copyright assignment if needed.

I  have no problem with that -- I'm already enjoying the advantages I
wanted from writing that code, anyway. Just out of curiosity: do  you
have already any schedule or estimation of when the FSF will consider
adding Vimpulse to the official Emacs distribution?

> 2.  On which Emacs and/or XEmacs versions did you test your patch?

I'm currently using:

    GNU  Emacs  23.1.50.2 (i686-pc-linux-gnu, GTK+ Version 2.16.1) of
    2009-10-11 on spleen

checked  out  from  CVS a few weeks ago, but right after reading your
message I thought of testing it on:

    GNU  Emacs  22.3.1  (i486-pc-linux-gnu,  GTK+  Version 2.16.2) of
    2009-06-26 on rivendell, modified by Debian

from  the  Debian package in Sid, and I realized that in Emacs 22 the
function activate-mark does not exist, so we'll have to take care  of
that difference. Besides that one detail, my modifications seem to be
working fine there too.

> 3.  Your patch got from GNU Mailman's admindb to my personal inbox,
> but not to the mailing list when I approved it.  So Alessandro must
> retrieve the patch from his own inbox too.  This is probably because
> you exceeded some size limit.  But anyway it looks like you patched
> the released version of Vimpulse.  Do you know how to use svn and
> emerge?  If so, could you please send a new version of your patch
> which patches the multi-file svn version of Vimpulse?  (Alessandro may
> make more requests of you.  For example, he may ask you to make the
> vimpulse-visual-replace-region dup removal a separate patch; but I
> think he probably won't ask that.)

I  do  use  SVN on a regular basis, at work as well as for keeping my
own stuff, just let me know the repository URL (the only  version  of
Vimpulse I know is the one I got from the Emacs Wiki) and I can patch
that. I've never used Gentoo though, so I have no  idea  how  to  use
emerge,  nor  how  does it relate to SVN besides installing it in the
local box (or were you talking about something different?)

> Thanks again for the patch.

My pleasure :)

Cheers,
-- 
José A. Romero L.
escherdragon at gmail.com
"The opposite of war is not peace, it's creation."
(Jonathan Larson)



More information about the implementations-list mailing list