[implementations-list] Welcome, Vegard, our newest committer

Sun Dec 27 22:51:15 CET 2009

I am replying to my own message with some followup comments.

On Sun, Dec 27, 2009 at 2:46 PM, Jason Spiro <jasonspiro3 at gmail.com> wrote:

> On Fri, Dec 25, 2009 at 7:53 PM, Vegard Øye <vegard_oye at hotmail.com> wrote:

>>> From: jasonspiro3 at gmail.com
>>> Date: Wed, 23 Dec 2009 22:38:08 -0500

[snip]

>> As for GNU Emacs 23.1, the problems are more easy to fix: first, cl.el
>> needs to be loaded, either by doing (require 'cl) before loading
>> Vimpulse or prepending (eval-when-compile (require 'cl)) to Vimpulse's
>> code.
>
> There was some discussion about cl.el on this list a few months ago.
> I don't remember what was concluded.  Please read it before you do
> anything relating to cl.el; once you have read it, do whatever you
> want.

Actually, I realize the discussion was a few years ago.  You can read
the discussion where I forwarded it, at
http://my-trac.assembla.com/vimpulse/ticket/2 -- "[PATCH] rewrite
viper-normalize-minor-mode-map-alist not to use cl.el's 'push' macro".

[snip]

> You can always commit bug fixes without asking.  :)  My concern is
> that new features, like like vimpulse-modal

The above is an incomplete paragraph.  I meant to write the following
paragraphs instead.

You can always commit bug fixes without asking.  :)

Since you are new, and since I'm not an elisp expert, I don't know the
quality of the new feature code you write.  I'm going to leave it for
Alessandro or anyone else on the list to review vimpulse-modal, which
is your first feature patch, especially since I am no longer
maintainer, and I am busy.  But I know Alessandro is busy too.  If you
want, you can write a mail to the list with a subject line something
like 'Call for a volunteer to review and test vimpulse-modal.el'.  If
anyone reviews it and tests it on any Emacs and says it is fine, you
may commit it.  If you called for a volunteer and nothing happened
after a month, then that shows that Vimpulse is sorely lacking active
maintainer power, and you can commit it yourself.

Once vimpulse-modal has been committed, then you can commit whatever
else you want.  When I was maintainer, I insisted that Vimpulse should
work just like Vim.  If someone wrote a new Vimpulse feature that
didn't work like Vim, I asked the submitter to get Vim to include that
new functionality first.  Now Alessandro is maintainer, and I don't
know what his ideas about this are.

    *  If Alessandro's ideas are like mine, then if you want to have
features that Bram refuses to add to Vim, then you should start a
project which consists of a set of addons to Vimpulse, and call it
something like "vimpulse-addons", and maintain it.  We won't mind.  :)
 And you still will be able to contribute to Vimpulse.

    *  If his ideas are not like mine, then do what he tells you to do.

[snip]

Kind regards,
-Jason