March 2013 - kune-commits - lists.ourproject.org

[Kune - Enhancement #70] Implement some kind of "/etc/init.d/kune reload" to reload configuration
by Redmine Comunes 08 Mar '13

08 Mar '13

Issue #70 has been updated by Pablo Ojanguren. File jmx-in-action-1.png added Implemented initial version following these steps: 1) Create MBean interface for class to manage KunePropertiesDefaultMBean <pre> package cc.kune.core.server.properties; /** * MBean interface for JMX management of server properties * */ public interface KunePropertiesDefaultMBean { String reload(); String getProperty(String key); void setProperty(String key, String value); } </pre> 2) Implement mbean interface new methods KunePropertiesDefault <pre> diff --git a/src/main/java/cc/kune/core/server/properties/KunePropertiesDefault.java b/src/main/java/cc/kune/core/server/properties/KunePropertiesDefault.java index aa8639f..ed79f6d 100644 --- a/src/main/java/cc/kune/core/server/properties/KunePropertiesDefault.java +++ b/src/main/java/cc/kune/core/server/properties/KunePropertiesDefault.java @@ -1,6 +1,6 @@ /* * - * Copyright (C) 2007-2012 The kune development team (see CREDITS for details) + * Copyright (C) 2007-2013 The kune development team (see CREDITS for details) * This file is part of kune. * * This program is free software: you can redistribute it and/or modify @@ -35,7 +35,7 @@ import com.google.inject.Singleton; @Singleton -public class KunePropertiesDefault implements KuneProperties { +public class KunePropertiesDefault implements KuneProperties, KunePropertiesDefaultMBean { public static final Log LOG = LogFactory.getLog(KunePropertiesDefault.class); private CompositeConfiguration config; private final String fileName; @@ -124,4 +124,33 @@ } } + @Override + public String reload() { + + String resultInfoStr = "OK"; + + try { + + loadConfiguration(); + + } catch (final ServerException e) { + + resultInfoStr = e.getMessage(); + } + + return resultInfoStr; + } + + @Override + public String getProperty(String key) { + + return this.get(key); + } + + @Override + public void setProperty(String key, String value) { + + this.setProperty(key, value); + } + } </pre> 3) Add mbean activation just after KuneProperties object is created DataSourceKunePersistModule <pre> diff --git a/src/main/java/cc/kune/core/server/persist/DataSourceKunePersistModule.java b/src/main/java/cc/kune/core/server/persist/DataSourceKunePersistModule.java index 5b097bf..2ae371b 100644 --- a/src/main/java/cc/kune/core/server/persist/DataSourceKunePersistModule.java +++ b/src/main/java/cc/kune/core/server/persist/DataSourceKunePersistModule.java @@ -21,8 +21,15 @@ import java.io.IOException; import java.io.InputStream; +import java.lang.management.ManagementFactory; import java.util.Properties; +import javax.management.InstanceAlreadyExistsException; +import javax.management.MBeanRegistrationException; +import javax.management.MBeanServer; +import javax.management.MalformedObjectNameException; +import javax.management.NotCompliantMBeanException; +import javax.management.ObjectName; import javax.persistence.EntityManager; import org.apache.commons.configuration.SystemConfiguration; @@ -220,6 +227,33 @@ final SystemConfiguration sysConf = new SystemConfiguration(); kuneConfig = settedProperties != null ? settedProperties : sysConf.getString("kune.server.config"); kuneProperties = new KunePropertiesDefault(kuneConfig); + + /* #70 Reload Configuration Properties via JMX */ + MBeanServer mbeanServer = ManagementFactory.getPlatformMBeanServer(); + ObjectName mbeanName = null; + try { + + mbeanName = new ObjectName("cc.kune.mbeans:type=KuneProperties"); + + } catch (MalformedObjectNameException e) { + e.printStackTrace(); + } catch (NullPointerException e) { + e.printStackTrace(); + } + + try { + + mbeanServer.registerMBean(kuneProperties, mbeanName); + + } catch (InstanceAlreadyExistsException e) { + e.printStackTrace(); + } catch (MBeanRegistrationException e) { + e.printStackTrace(); + } catch (NotCompliantMBeanException e) { + e.printStackTrace(); + } + + log4Conf = sysConf.getString("log4j.configuration"); } </pre> 4) Tested successfully using jconsole through local jetty-java process (see attached picture) *Next steps* * Remote access to JMX Mbeans hasn't been tested. Maybe jetty additional configuration is needed. (in progress) * Regression test. Unknown collateral effects when some properties are changed (e.g. db connection?) * To change a property doesn't imply to system be aware of it. If some object has already read the property (e.g. on its constructor) won't get new value anyway. Maybe JMX event feature should be enabled for these classes. * It only affects to server side of RPC server. How are changes populated to GWT client? ---------------------------------------- Enhancement #70: Implement some kind of "/etc/init.d/kune reload" to reload configuration http://redmine.ourproject.org/issues/70#change-742 * Author: Vicente J. Ruiz Jurado * Status: New * Priority: Normal * Assignee: Pablo Ojanguren * Category: Server side * Target version: * Resolution: * Tags: ---------------------------------------- Related http://ykyuen.wordpress.com/2010/07/26/jetty-stop-a-jetty-server-by-command/ http://wiki.eclipse.org/Jetty/Howto/Secure_Termination http://irc.codehaus.org/display/JETTY/How+to+gracefully+shutdown http://ptrthomas.wordpress.com/2009/01/24/how-to-start-and-stop-jetty-revis… http://eureka.ykyuen.info/2010/07/26/jetty-stop-a-jetty-server-by-command/ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Enhancement #70] Implement some kind of "/etc/init.d/kune reload" to reload configuration
by Redmine Comunes 06 Mar '13

06 Mar '13

Issue #70 has been updated by Vicente J. Ruiz Jurado. Assignee changed from Vicente J. Ruiz Jurado to Pablo Ojanguren ---------------------------------------- Enhancement #70: Implement some kind of "/etc/init.d/kune reload" to reload configuration http://redmine.ourproject.org/issues/70#change-741 * Author: Vicente J. Ruiz Jurado * Status: New * Priority: Normal * Assignee: Pablo Ojanguren * Category: Server side * Target version: * Resolution: * Tags: ---------------------------------------- Related http://ykyuen.wordpress.com/2010/07/26/jetty-stop-a-jetty-server-by-command/ http://wiki.eclipse.org/Jetty/Howto/Secure_Termination http://irc.codehaus.org/display/JETTY/How+to+gracefully+shutdown http://ptrthomas.wordpress.com/2009/01/24/how-to-start-and-stop-jetty-revis… http://eureka.ykyuen.info/2010/07/26/jetty-stop-a-jetty-server-by-command/ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Enhancement #70] (New) Implement some kind of "/etc/init.d/kune reload" to reload configuration
by Redmine Comunes 06 Mar '13

06 Mar '13

Issue #70 has been updated by Vicente J. Ruiz Jurado. Status changed from Closed to New % Done changed from 100 to 0 Resolution deleted (fixed) Closed by error, sorry... ---------------------------------------- Enhancement #70: Implement some kind of "/etc/init.d/kune reload" to reload configuration http://redmine.ourproject.org/issues/70#change-740 * Author: Vicente J. Ruiz Jurado * Status: New * Priority: Normal * Assignee: Vicente J. Ruiz Jurado * Category: Server side * Target version: * Resolution: * Tags: ---------------------------------------- Related http://ykyuen.wordpress.com/2010/07/26/jetty-stop-a-jetty-server-by-command/ http://wiki.eclipse.org/Jetty/Howto/Secure_Termination http://irc.codehaus.org/display/JETTY/How+to+gracefully+shutdown http://ptrthomas.wordpress.com/2009/01/24/how-to-start-and-stop-jetty-revis… http://eureka.ykyuen.info/2010/07/26/jetty-stop-a-jetty-server-by-command/ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Enhancement #286] Make kune googleable/searchable using hash bangs #! instead of # in hashs
by Redmine Comunes 04 Mar '13

04 Mar '13

Issue #286 has been updated by Vicente J. Ruiz Jurado. Subject changed from Make kune googleable using hash bangs #! instead of # in hashs to Make kune googleable/searchable using hash bangs #! instead of # in hashs ---------------------------------------- Enhancement #286: Make kune googleable/searchable using hash bangs #! instead of # in hashs http://redmine.ourproject.org/issues/286#change-736 * Author: Vicente J. Ruiz Jurado * Status: In Progress * Priority: Normal * Assignee: Vicente J. Ruiz Jurado * Category: * Target version: * Resolution: * Tags: ---------------------------------------- More info: https://developers.google.com/webmasters/ajax-crawling/docs/getting-started -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Enhancement #286] (In Progress) Make kune googleable using hash bangs #! instead of # in hashs
by Redmine Comunes 04 Mar '13

04 Mar '13

Issue #286 has been updated by Vicente J. Ruiz Jurado. Status changed from Closed to In Progress Assignee changed from Samer - to Vicente J. Ruiz Jurado % Done changed from 100 to 50 Reopened. Current status: - Sitemap is not yet generated in large sites - Page static generation via htmlunit perf issues - minor issues like #438 Urls to test: http://www.kune.cc/?_escaped_fragment_=admin http://kune.beta.iepala.es/sitemap.xml versus http://kune.cc/sitemap.xml ---------------------------------------- Enhancement #286: Make kune googleable using hash bangs #! instead of # in hashs http://redmine.ourproject.org/issues/286#change-735 * Author: Vicente J. Ruiz Jurado * Status: In Progress * Priority: Normal * Assignee: Vicente J. Ruiz Jurado * Category: * Target version: * Resolution: * Tags: ---------------------------------------- More info: https://developers.google.com/webmasters/ajax-crawling/docs/getting-started -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Defect #511] (New) Tutorials last slide points inexistent old feedback button
by Redmine Comunes 03 Mar '13

03 Mar '13

Issue #511 has been reported by Samer -. ---------------------------------------- Defect #511: Tutorials last slide points inexistent old feedback button http://redmine.ourproject.org/issues/511 * Author: Samer - * Status: New * Priority: Low * Assignee: * Category: * Target version: * Resolution: * Tags: easy ---------------------------------------- All the SVG tutorials end with the same slide: one with an arrow pointing the Feedback button. However, the feedback button has changed its place, and not it's not where the arrow points :P The arrow should be redirected. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 0

[Kune - Defect #510] (New) Add some more indexes to db
by Redmine Comunes 01 Mar '13

01 Mar '13

Issue #510 has been reported by Vicente J. Ruiz Jurado. ---------------------------------------- Defect #510: Add some more indexes to db http://redmine.ourproject.org/issues/510 * Author: Vicente J. Ruiz Jurado * Status: New * Priority: High * Assignee: * Category: * Target version: * Resolution: * Tags: ---------------------------------------- http://stackoverflow.com/questions/3533301/creating-indexes-on-db-with-hibe… one missing is createdOn in group table (thanks to http://kune.cc/#pablojan) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 1

[Kune - Defect #438] (New) htmlunit generate tmp files that are not removed
by Redmine Comunes 01 Mar '13

01 Mar '13

Issue #438 has been reported by Vicente J. Ruiz Jurado. ---------------------------------------- Defect #438: htmlunit generate tmp files that are not removed http://redmine.ourproject.org/issues/438 * Author: Vicente J. Ruiz Jurado * Status: New * Priority: Normal * Assignee: * Category: * Target version: * Resolution: * Tags: ---------------------------------------- http://www.julespotvin.com/?p=17 http://old.nabble.com/tmp-files-td31363960.html http://sourceforge.net/p/htmlunit/bugs/1344/ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://redmine.ourproject.org/my/account

1 6