[implementations-list] Vimpulse: vi* and va* object selection implementation proposal
Hello Vim fans, This is about the Vimpulse vim emulation for emacs. I've made some modifications to Vimpulse in order to add visual selection of text objects (vi* and va*) and a few other details, namely selection widening (e.g. try doing "va(" on some sexp and pressing "_" one or more times) and setting and activating the emacs mark when entering visual mode. Besides, I noticed that version 0.3.0 of Vimpulse contains three versions of the vimpulse-visual-replace- region function. I fixed that too. @Jason S, Alessandro P.: Would you have a look at it and let me know what you think? I'm sending in attachment the patch, as well as an already patched version of Vimpulse 0.3.0. Cheers, -- José A. Romero L. [email protected] "We who cut mere stones must always be envisioning cathedrals." (Quarry worker's creed)
2009/11/21 José A. Romero L. <[email protected]> wrote:
I've made some modifications to Vimpulse in order to add visual selection of text objects (vi* and va*) and a few other details, namely selection widening (e.g. try doing "va(" on some sexp and pressing "_" one or more times) and setting and activating the emacs mark when entering visual mode. Besides, I noticed that version 0.3.0 of Vimpulse contains three versions of the vimpulse-visual-replace- region function. I fixed that too.
Hi José, Thank you very much for the patch. It's people like you -- the people who contribute code -- who cause Vimpulse to be as good as it is. I'm no longer maintainer, and plus I never use text objects, only ) and ( like in "d)", so I haven't taken a look at your code. I'll let Alessandro look. First, some friendly suggestions :) * Next time you write a patch, write [PATCH] in the subject line. I have done this for you now. * There's no need to attach all of Vimpulse -- just the .patch file. That is why your mail was automatically held until I approved it: your mail exceeded I think 128K. Now some questions: 1. Do you agree that when Vimpulse finally gets into Emacs, you will be able to mail or fax in a copyright assignment saying that your work will no longer be copyrighted by you but by the FSF? Can you please private-mail to me and Alessandro your phone number and either your home or work snail mail address? We don't plan to use it except for asking you for copyright assignment if needed. 2. On which Emacs and/or XEmacs versions did you test your patch? 3. Your patch got from GNU Mailman's admindb to my personal inbox, but not to the mailing list when I approved it. So Alessandro must retrieve the patch from his own inbox too. This is probably because you exceeded some size limit. But anyway it looks like you patched the released version of Vimpulse. Do you know how to use svn and emerge? If so, could you please send a new version of your patch which patches the multi-file svn version of Vimpulse? (Alessandro may make more requests of you. For example, he may ask you to make the vimpulse-visual-replace-region dup removal a separate patch; but I think he probably won't ask that.) Thanks again for the patch. Kind regards, -Jason -- Jason Spiro: software/web developer, packager, trainer, IT consultant. I support Linux, UNIX, Windows, and more. Contact me to discuss your needs. +1 (416) 992-3445 / www.jspiro.com
participants (2)
-
Jason Spiro -
José A. Romero L.