[implementations-list] Re: Re: [PATCH] Vimpulse: vi* and va* object selection implementation proposal
Hi Jason, 2009/11/22 <[email protected]>: (...)
* Next time you write a patch, write [PATCH] in the subject line. I have done this for you now.
Sure will, thanks.
* There's no need to attach all of Vimpulse -- just the .patch file. That is why your mail was automatically held until I approved it: your mail exceeded I think 128K.
I see. When considering a patch I usually like to examine both the patch itself and the modified code, to see how it "merges" with the rest. But sure, next time I will attach only the patch.
Now some questions:
1. Do you agree that when Vimpulse finally gets into Emacs, you will be able to mail or fax in a copyright assignment saying that your work will no longer be copyrighted by you but by the FSF? Can you please private-mail to me and Alessandro your phone number and either your home or work snail mail address? We don't plan to use it except for asking you for copyright assignment if needed.
I have no problem with that -- I'm already enjoying the advantages I wanted from writing that code, anyway. Just out of curiosity: do you have already any schedule or estimation of when the FSF will consider adding Vimpulse to the official Emacs distribution?
2. On which Emacs and/or XEmacs versions did you test your patch?
I'm currently using: GNU Emacs 23.1.50.2 (i686-pc-linux-gnu, GTK+ Version 2.16.1) of 2009-10-11 on spleen checked out from CVS a few weeks ago, but right after reading your message I thought of testing it on: GNU Emacs 22.3.1 (i486-pc-linux-gnu, GTK+ Version 2.16.2) of 2009-06-26 on rivendell, modified by Debian from the Debian package in Sid, and I realized that in Emacs 22 the function activate-mark does not exist, so we'll have to take care of that difference. Besides that one detail, my modifications seem to be working fine there too.
3. Your patch got from GNU Mailman's admindb to my personal inbox, but not to the mailing list when I approved it. So Alessandro must retrieve the patch from his own inbox too. This is probably because you exceeded some size limit. But anyway it looks like you patched the released version of Vimpulse. Do you know how to use svn and emerge? If so, could you please send a new version of your patch which patches the multi-file svn version of Vimpulse? (Alessandro may make more requests of you. For example, he may ask you to make the vimpulse-visual-replace-region dup removal a separate patch; but I think he probably won't ask that.)
I do use SVN on a regular basis, at work as well as for keeping my own stuff, just let me know the repository URL (the only version of Vimpulse I know is the one I got from the Emacs Wiki) and I can patch that. I've never used Gentoo though, so I have no idea how to use emerge, nor how does it relate to SVN besides installing it in the local box (or were you talking about something different?)
Thanks again for the patch.
My pleasure :) Cheers, -- José A. Romero L. escherdragon at gmail.com "The opposite of war is not peace, it's creation." (Jonathan Larson)
2009/11/22 José A. Romero L. <[email protected]> wrote:
I have no problem with that -- I'm already enjoying the advantages I wanted from writing that code, anyway. Just out of curiosity: do you have already any schedule or estimation of when the FSF will consider adding Vimpulse to the official Emacs distribution?
I don't know. IMO it's still too buggy, so they shouldn't include it.
... I realized that in Emacs 22 the function activate-mark does not exist, so we'll have to take care of that difference. Besides that one detail, my modifications seem to be working fine there too.
Thanks for retesting. It would be appreciated if you would try XEmacs too. It's a small download if you have broadband Internet access; only about 5-10 MB.
I do use SVN on a regular basis, at work as well as for keeping my own stuff, just let me know the repository URL (the only version of Vimpulse I know is the one I got from the Emacs Wiki) and I can patch that. I've never used Gentoo though, so I have no idea how to use emerge, nor how does it relate to SVN besides installing it in the local box (or were you talking about something different?)
There's a link to our repo and bugtracker at http://www.assembla.com/spaces/vimpulse -- in fact, I think it would be best if you would send your patch to the bugtracker instead of to the mailing list. That way, it is guaranteed not to get lost. But if you do submit the next version of your patch to the mailing list, please send a mail to the mailing list telling us it is now there. The emerge I was talking about is not the Gentoo package installation script. The emerge I meant is part of ediff. I believe it might let you more easily apply your patch to the SVN version of Vimpulse. Check the Emacs manual for more info.
2009/11/23 Jason Spiro <[email protected]>:
2009/11/22 José A. Romero L. <[email protected]> wrote: (...)
have already any schedule or estimation of when the FSF will consider adding Vimpulse to the official Emacs distribution?
I don't know. IMO it's still too buggy, so they shouldn't include it.
Just let me know when it gets scheduled for inclusion, then I'll send my data to you or Alessandro, OK?
... I realized that in Emacs 22 the function activate-mark does not exist, so we'll have to take care of that difference. Besides that one detail, my modifications seem to be working fine there too.
Thanks for retesting. It would be appreciated if you would try XEmacs too. It's a small download if you have broadband Internet access; only about 5-10 MB.
Unfortunately I didn't manage (again - this is not the first time I try) to make XEmacs work correctly in my system, neither after installing the standard Debian packages in Sid, nor compiling it myself. I have tried it a few times, but always came back running to GNU Emacs, to the point that I have expressly ruled out compatibility with it in my own projects (e.g. http://www.emacswiki.org/emacs/Sunrise_Commander). Anyway, I've left out the call to activate-mark in the patches I've just submitted to your bug track system. For me, Vimpulse works definitely better with it, but probably it's you who should decide whether to call (or not) activate-mark every time the user hits "v". (...)
There's a link to our repo and bugtracker at http://www.assembla.com/spaces/vimpulse -- in fact, I think it would be best if you would send your patch to the bugtracker instead of to the mailing list. That way, it is guaranteed not to get lost. But if you do submit the next version of your patch to the mailing list, please send a mail to the mailing list telling us it is now there.
Just done. And here's the e-mail ;) I've divided the original patch into 3 smaller ones: one for removing the extra definitions of the function vimpulse-visual-replace-region, and two for the vi*/va* stuff, the first one with standard gvim behavior, and the second one with a function of my own invention that IMO makes that behavior more useful. Just give it a try and decide if you like it too or not.
The emerge I was talking about is not the Gentoo package installation script. The emerge I meant is part of ediff. I believe it might let you more easily apply your patch to the SVN version of Vimpulse. Check the Emacs manual for more info. (...)
Cool stuff, thanks for the tip. I've been using plain diff and patch so long that it feels like second nature, but I'll definitely give emerge a try once I find the time to read the docs. Cheers, -- José A. Romero L. escherdragon at gmail.com "We who cut mere stones must always be envisioning cathedrals." (Quarry worker's creed)
Hi everyone, i'm pretty busy these days, so I guess I'll take a look maybe during the Xmas holiday. Sorry for the absence :) Alessandro Piras 2009/11/29 José A. Romero L. <[email protected]>:
2009/11/23 Jason Spiro <[email protected]>:
2009/11/22 José A. Romero L. <[email protected]> wrote: (...)
have already any schedule or estimation of when the FSF will consider adding Vimpulse to the official Emacs distribution?
I don't know. IMO it's still too buggy, so they shouldn't include it.
Just let me know when it gets scheduled for inclusion, then I'll send my data to you or Alessandro, OK?
... I realized that in Emacs 22 the function activate-mark does not exist, so we'll have to take care of that difference. Besides that one detail, my modifications seem to be working fine there too.
Thanks for retesting. It would be appreciated if you would try XEmacs too. It's a small download if you have broadband Internet access; only about 5-10 MB.
Unfortunately I didn't manage (again - this is not the first time I try) to make XEmacs work correctly in my system, neither after installing the standard Debian packages in Sid, nor compiling it myself. I have tried it a few times, but always came back running to GNU Emacs, to the point that I have expressly ruled out compatibility with it in my own projects (e.g. http://www.emacswiki.org/emacs/Sunrise_Commander).
Anyway, I've left out the call to activate-mark in the patches I've just submitted to your bug track system. For me, Vimpulse works definitely better with it, but probably it's you who should decide whether to call (or not) activate-mark every time the user hits "v".
(...)
There's a link to our repo and bugtracker at http://www.assembla.com/spaces/vimpulse -- in fact, I think it would be best if you would send your patch to the bugtracker instead of to the mailing list. That way, it is guaranteed not to get lost. But if you do submit the next version of your patch to the mailing list, please send a mail to the mailing list telling us it is now there.
Just done. And here's the e-mail ;) I've divided the original patch into 3 smaller ones: one for removing the extra definitions of the function vimpulse-visual-replace-region, and two for the vi*/va* stuff, the first one with standard gvim behavior, and the second one with a function of my own invention that IMO makes that behavior more useful. Just give it a try and decide if you like it too or not.
The emerge I was talking about is not the Gentoo package installation script. The emerge I meant is part of ediff. I believe it might let you more easily apply your patch to the SVN version of Vimpulse. Check the Emacs manual for more info. (...)
Cool stuff, thanks for the tip. I've been using plain diff and patch so long that it feels like second nature, but I'll definitely give emerge a try once I find the time to read the docs.
Cheers, -- José A. Romero L. escherdragon at gmail.com "We who cut mere stones must always be envisioning cathedrals." (Quarry worker's creed)
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
participants (3)
-
Alessandro Piras -
Jason Spiro -
José A. Romero L.