evil not entering emacs-state in magit-key-mode even if magit-key-mode is listed in evil-emacs-state-modes
I got this issue in one of the last updates i did. I'm installing both packages from melpa. I temporarily solved the issue using an advice, as magit-key-mode has no magit-key-mode-hook - I don't know if this is related at all. By the way, great job with evil in general, it's working great apart from this small issue! Cheers, Alessandro Piras
On 2012-11-05, Alessandro Piras <[email protected]> wrote:
I got this issue in one of the last updates i did. I'm installing both packages from melpa. I temporarily solved the issue using an advice, as magit-key-mode has no magit-key-mode-hook - I don't know if this is related at all.
Hm, I think this is actually related, because vegard's latest change to evil's initialization code probably relies on this hook (or more specifically on the mode being defined by `define-minor-mode'). Please add a report to the bug tracker (and assign to Vegard ;)). Best, Frank
Hi, thanks for the fix! Now magit works correctly without my advice, but there is another problem: When doing C-x C-f with ido mode activated, it comes up in normal state! Adding minibuffer-inactive-mode to evil-emacs-state-modes seems to solve the issue. Alessandro Piras On 6 November 2012 18:37, Vegard Øye <[email protected]> wrote:
On 2012-11-05 17:22 +0100, Alessandro Piras wrote:
I got this issue in one of the last updates i did.
Should be fixed in commit 2b8c308. (If not, please open a new issue in the bug tracker.)
-- Vegard
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2012-11-07, Alessandro Piras <[email protected]> wrote:
Hi, thanks for the fix! Now magit works correctly without my advice, but there is another problem: When doing C-x C-f with ido mode activated, it comes up in normal state! Adding minibuffer-inactive-mode to evil-emacs-state-modes seems to solve the issue.
Hm, currently evil should not be activated in any minibuffer. Seems as if the latest work on the initialization code causes this bug. Can you please check if the following change fixes this bug? (I doesn't seem to occur with my emacs version). ========== diff -r cfd40950b001 evil-core.el --- a/evil-core.el Tue Nov 06 14:20:08 2012 +0100 +++ b/evil-core.el Wed Nov 07 13:44:59 2012 +0100 @@ -286,7 +286,8 @@ (defadvice evil-mode-check-buffers (before start-evil activate) "Determine the initial state." (dolist (buffer evil-mode-buffers) - (when (buffer-live-p buffer) + (when (and (buffer-live-p buffer) + (not (minibufferp))) (with-current-buffer buffer (evil-initialize-state))))) ========== Best regards, Frank
I'm not sure was the cause this commit or one of before, but after I pulled latest code my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work. I described this in: https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-m... Anyone with the same issue? Regards, Sanel On Wed, Nov 7, 2012 at 12:05 PM, Alessandro Piras <[email protected]> wrote:
Hi, thanks for the fix! Now magit works correctly without my advice, but there is another problem: When doing C-x C-f with ido mode activated, it comes up in normal state! Adding minibuffer-inactive-mode to evil-emacs-state-modes seems to solve the issue.
Alessandro Piras
On 6 November 2012 18:37, Vegard Øye <[email protected]> wrote:
On 2012-11-05 17:22 +0100, Alessandro Piras wrote:
I got this issue in one of the last updates i did.
Should be fixed in commit 2b8c308. (If not, please open a new issue in the bug tracker.)
-- Vegard
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2012-11-07, Sanel Zukan <[email protected]> wrote:
I'm not sure was the cause this commit or one of before, but after I pulled latest code my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work.
I described this in: https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-m...
Anyone with the same issue?
I can't reproduce that. Which emacs version do you use? What happens if you start the server in evil's source directory with emacs -Q -L . -l evil.el --eval "(evil-mode 1)" --daemon (this loads nothing but evil)? Frank
I'm using Emacs 24.1.1 on Fedora 17. I did started it as you suggested, and done this: 1. opened client with 'emacsclient -t' 2. open file (:e ~/foo) 3. tried to do :q! but when I hit 'q', I'm getting: Defining kbd macro... After this, everything gets messed up, even 'M-x' doesn't work (tried M-x 'emacs-version' but after hitting 'e' I got 'End of buffer'). This is always reproducible. Regards, Sanel On Wed, Nov 7, 2012 at 3:46 PM, Frank Fischer <[email protected]> wrote:
On 2012-11-07, Sanel Zukan <[email protected]> wrote:
I'm not sure was the cause this commit or one of before, but after I pulled latest code my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work.
I described this in: https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-m...
Anyone with the same issue?
I can't reproduce that. Which emacs version do you use? What happens if you start the server in evil's source directory with
emacs -Q -L . -l evil.el --eval "(evil-mode 1)" --daemon
(this loads nothing but evil)?
Frank
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
Just recompiled emacs 24.2. The same behaviour. Regards, Sanel On Wed, Nov 7, 2012 at 4:19 PM, Sanel Zukan <[email protected]> wrote:
I'm using Emacs 24.1.1 on Fedora 17. I did started it as you suggested, and done this:
1. opened client with 'emacsclient -t' 2. open file (:e ~/foo) 3. tried to do :q! but when I hit 'q', I'm getting: Defining kbd macro...
After this, everything gets messed up, even 'M-x' doesn't work (tried M-x 'emacs-version' but after hitting 'e' I got 'End of buffer').
This is always reproducible.
Regards, Sanel
On Wed, Nov 7, 2012 at 3:46 PM, Frank Fischer <[email protected]> wrote:
On 2012-11-07, Sanel Zukan <[email protected]> wrote:
I'm not sure was the cause this commit or one of before, but after I pulled latest code my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work.
I described this in: https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-m...
Anyone with the same issue?
I can't reproduce that. Which emacs version do you use? What happens if you start the server in evil's source directory with
emacs -Q -L . -l evil.el --eval "(evil-mode 1)" --daemon
(this loads nothing but evil)?
Frank
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
On 2012-11-07, Sanel Zukan <[email protected]> wrote:
Just recompiled emacs 24.2. The same behaviour.
I still do not have the behavior. Can you bisect to determine which commit caused the problem? And maybe try the patch I posted somewhere else today: ========== (defadvice evil-mode-check-buffers (before start-evil activate) "Determine the initial state." (dolist (buffer evil-mode-buffers) - (when (buffer-live-p buffer) + (when (and (buffer-live-p buffer) + (not (minibufferp))) (with-current-buffer buffer (evil-initialize-state))))) ========== I just want to make sure that evil is not initialized in the minibuffer. (You can also check whether evil is active in the minibuffer: after typing : first type i then q!. If this works then evil is active in the minibuffer although it should not be). Frank
Regards, Sanel
On Wed, Nov 7, 2012 at 4:19 PM, Sanel Zukan <[email protected]> wrote:
I'm using Emacs 24.1.1 on Fedora 17. I did started it as you suggested, and done this:
1. opened client with 'emacsclient -t' 2. open file (:e ~/foo) 3. tried to do :q! but when I hit 'q', I'm getting: Defining kbd macro...
After this, everything gets messed up, even 'M-x' doesn't work (tried M-x 'emacs-version' but after hitting 'e' I got 'End of buffer').
This is always reproducible.
Regards, Sanel
On Wed, Nov 7, 2012 at 3:46 PM, Frank Fischer <[email protected]> wrote:
On 2012-11-07, Sanel Zukan <[email protected]> wrote:
I'm not sure was the cause this commit or one of before, but after I pulled latest code my 'emacs --daemon' setup for terminal (emacsclient -t) stopped to work.
I described this in: https://bitbucket.org/lyro/evil/issue/220/emacs-daemon-and-open-file-in-ex-m...
Anyone with the same issue?
I can't reproduce that. Which emacs version do you use? What happens if you start the server in evil's source directory with
emacs -Q -L . -l evil.el --eval "(evil-mode 1)" --daemon
(this loads nothing but evil)?
Frank
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
-- Frank Fischer Chemnitz University of Technology, Department of Mathematics eMail: [email protected] Tel.: +49 (371) 531-36913
Ok, I could reproduce the error with the correct Emacs version and committed a fix. The reason was indeed that evil has been activated in the minibuffer. Frank
You were faster... :) Works now. I didn't know minibuffer has ability to load major mode. Thanks for the fix. Sanel On Wed, Nov 7, 2012 at 8:56 PM, Frank Fischer <[email protected]> wrote:
Ok, I could reproduce the error with the correct Emacs version and committed a fix. The reason was indeed that evil has been activated in the minibuffer.
Frank
_______________________________________________ implementations-list mailing list [email protected] https://lists.ourproject.org/cgi-bin/mailman/listinfo/implementations-list
participants (4)
-
Alessandro Piras -
Frank Fischer -
Sanel Zukan -
Vegard Øye