Hi, In the line below, try doing yE with the cursor on the + sign and then pasting somewhere: +foo bar Vimpulse should only grab +foo, but it grabs bar as well. If you remove the +, it grabs only foo as expected.
On Wed, Jul 28, 2010 at 11:12 AM, Stephen Bach <[email protected]> wrote:
Hi,
In the line below, try doing yE with the cursor on the + sign and then pasting somewhere:
+foo bar
Vimpulse should only grab +foo, but it grabs bar as well. If you remove the +, it grabs only foo as expected.
Which version of vimpulse are you using? (from git?) I'm unable to reproduce your issue with the latest version in git.
On Wed, Jul 28, 2010 at 11:31 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:12 AM, Stephen Bach <[email protected]> wrote:
Hi,
In the line below, try doing yE with the cursor on the + sign and then pasting somewhere:
+foo bar
Vimpulse should only grab +foo, but it grabs bar as well. If you remove the +, it grabs only foo as expected.
Which version of vimpulse are you using? (from git?)
I'm unable to reproduce your issue with the latest version in git.
Nevermind, I see it now. The + sign is important to reproduce the bug :) I can confirm this issue with revision 08394a0c545b767b4e724c50e84bb2c35a2dcd61 Tim
On Wed, Jul 28, 2010 at 11:33 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:31 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:12 AM, Stephen Bach <[email protected]> wrote:
Hi,
In the line below, try doing yE with the cursor on the + sign and then pasting somewhere:
+foo bar
Vimpulse should only grab +foo, but it grabs bar as well. If you remove the +, it grabs only foo as expected.
Which version of vimpulse are you using? (from git?)
I'm unable to reproduce your issue with the latest version in git.
Nevermind, I see it now. The + sign is important to reproduce the bug :) I can confirm this issue with revision 08394a0c545b767b4e724c50e84bb2c35a2dcd61
Tim
The problem is vimpulse-end-of-Word is receiving an arg of '(nil . 114). The 114 is causing the behavior. If you force it to nil, it doesn't happen. Still researching...
On Thu, Jul 29, 2010 at 7:58 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:33 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:31 AM, Tim Harper <[email protected]> wrote:
On Wed, Jul 28, 2010 at 11:12 AM, Stephen Bach <[email protected]> wrote:
Hi,
In the line below, try doing yE with the cursor on the + sign and then pasting somewhere:
+foo bar
Vimpulse should only grab +foo, but it grabs bar as well. If you remove the +, it grabs only foo as expected.
Which version of vimpulse are you using? (from git?)
I'm unable to reproduce your issue with the latest version in git.
Nevermind, I see it now. The + sign is important to reproduce the bug :) I can confirm this issue with revision 08394a0c545b767b4e724c50e84bb2c35a2dcd61
Tim
The problem is vimpulse-end-of-Word is receiving an arg of '(nil . 114). The 114 is causing the behavior. If you force it to nil, it doesn't happen.
Still researching...
The bug appears to have been introduced in this commit: http://github.com/timcharper/vimpulse/commit/d650a459#L1R983 I can't tell why that was added (the hunk I commented on in that link). I've removed it, and not only does it fix this bug, but everything seems to behave just fine. I wonder if it was accidently included? How do I run the automated test suite included with vimpulse? Is it in working condition? (eval-buffer doesn't work for me, it seems)
It reverts part of a change from d650a459, which I think was accidently included. Said change advertised to fix an issue with diW. After this change, however, diW appears to function just fine, while fixing the undesirable behavior aforementioned in the subject --- vimpulse-viper-function-redefinitions.el | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/vimpulse-viper-function-redefinitions.el b/vimpulse-viper-function-redefinitions.el index d5f6fbd..1debdf5 100644 --- a/vimpulse-viper-function-redefinitions.el +++ b/vimpulse-viper-function-redefinitions.el @@ -1103,10 +1103,7 @@ docstring. The variable becomes buffer-local whenever set.") (com (viper-getcom arg))) (cond (com - (viper-move-marker-locally 'viper-com-point (point)) - (when (and (not (viper-looking-at-alpha)) - (not (viper-looking-at-alphasep))) - (setq val (1+ val)))) + (viper-move-marker-locally 'viper-com-point (point))) ((save-excursion (viper-forward-char-carefully) (memq (char-syntax (char-after)) '(?\ ?- nil))) -- 1.7.2
Thanks for the fix; applied in commit [31a5fab7b1]. I added some regression tests in [b0bba2dcdf] and unless I'm missing something, "E" is now working properly. -- Vegard
participants (3)
-
Stephen Bach -
Tim Harper -
Vegard Øye