Re: Add vimpulse-want-quit-like-Vim customization variable.
Vegard, I don't understand purpose or motivation of this change (commit af7bc2369c72a9), could you please comment (and could you (and others whom it may concern) *please* add such comments to the commit messages as well)? Apart from the fact that I don't get why you made the change in the first place, I see other issues as well: Viper already includes a :quit command, which is about as faithful to the Vim behaviour as the trivial version used by Vimpulse.[1] Now you add a variable whose name suggests that it will be "like Vim", but it actually triggers the Vimpulse behaviour... [I don't care other than that it's weird (I don't use any Ex commands at all).] Thanks, Štěpán [1] Actually, each of the commands, i.e. `ex-quit' on one hand and the Vimpulse version on the other, pick a different part of what Vim's :quit command does.
On 2010-07-31 21:01, Štěpán Němec wrote:
I don't understand purpose or motivation of this change (commit af7bc2369c72a9), could you please comment (and could you (and others whom it may concern) *please* add such comments to the commit messages as well)?
Yeah, I can understand that the brief summary line by itself isn't very telling. I'll be more verbose from now on, starting with commit [f35a5dce0b]. :)
Apart from the fact that I don't get why you made the change in the first place, I see other issues as well: Viper already includes a :quit command, which is about as faithful to the Vim behaviour as the trivial version used by Vimpulse. ... Actually, each of the commands, i.e. `ex-quit' on one hand and the Vimpulse version on the other, pick a different part of what Vim's :quit command does.
I made the change because a user missed Viper's `ex-quit'. But, as you rightly point out, neither `ex-quit' nor `save-buffers-kill-emacs' emulate :quit completely, making `vimpulse-want-quit-like-Vim' something of a misnomer. The better solution would be to write a quit function that implemented both parts of Vim's :quit. -- Vegard
Vegard Øye <[email protected]> writes:
On 2010-07-31 21:01, Štěpán Němec wrote:
I don't understand purpose or motivation of this change (commit af7bc2369c72a9), could you please comment (and could you (and others whom it may concern) *please* add such comments to the commit messages as well)?
Yeah, I can understand that the brief summary line by itself isn't very telling. I'll be more verbose from now on, starting with commit [f35a5dce0b]. :)
Thank you!
Apart from the fact that I don't get why you made the change in the first place, I see other issues as well: Viper already includes a :quit command, which is about as faithful to the Vim behaviour as the trivial version used by Vimpulse. ... Actually, each of the commands, i.e. `ex-quit' on one hand and the Vimpulse version on the other, pick a different part of what Vim's :quit command does.
I made the change because a user missed Viper's `ex-quit'. But, as you rightly point out, neither `ex-quit' nor `save-buffers-kill-emacs' emulate :quit completely, making `vimpulse-want-quit-like-Vim' something of a misnomer. The better solution would be to write a quit function that implemented both parts of Vim's :quit.
Yes. That could also address a recent feature request for :quit!/ZQ to quit Emacs unconditionally (although I don't see an easy way to do that). Štěpán P.S.: This is not the first time you made a change because "some user" requested it (e.g. the TAB key thing recently) -- I assume you get such requests off-list? I wonder why users don't write to this list so that we could have some more feedback and possibly prevent misunderstandings or "fixes" introducing other problems right away (of course you can always do whatever you want in the end (were there any doubts about that? :-)), but AFAICT you're not opposed to considering input from wider user base. Maybe you could cc such discussions/requests to the list?)
On 2010-08-02 13:28, ??t??p??n N??mec wrote:
This is not the first time you made a change because "some user" requested it (e.g. the TAB key thing recently) -- I assume you get such requests off-list?
Yes. I've got quite a few recently. Maybe a blog post somewhere is generating Vimpulse interest.
I wonder why users don't write to this list so that we could have some more feedback and possibly prevent misunderstandings or "fixes" introducing other problems right away
They don't do that, of course, because they use 0.4, whose headers don't place very much emphasis on the mailing list.[1] Rather, my e-mail address is listed at the top, and stands apart from the other links so as to be more visible. In commit [b174ba8093] (post 0.4),[2] I added a line below it to encourage people to use the list instead. [1] http://www.assembla.com/code/vimpulse/git/nodes/Header?rev=393882f5f3 [2] http://www.assembla.com/code/vimpulse/git/nodes/Header?rev=b174ba8093
Maybe you could cc such discussions/requests to the list?
Sure. -- Vegard
participants (2)
-
Vegard Øye -
Štěpán Němec